You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/27 12:11:55 UTC
[GitHub] [superset] krsnik93 opened a new issue #14373: Custom plugins entry not visible in settings menu after enabling feature flag
krsnik93 opened a new issue #14373:
URL: https://github.com/apache/superset/issues/14373
I have added `"DYNAMIC_PLUGINS": True` to my `superset_config.py`, but the Plugins entry does not appear in the Settings menu. I have previously enabled `ROW_LEVEL_SECURITY` and can toggle it and see the effect. My feature flags:
```
FEATURE_FLAGS = {
"ROW_LEVEL_SECURITY": True,
"VERSIONED_EXPORT": True,
"DYNAMIC_PLUGINS": True,
"THUMBNAILS": True,
"THUMBNAILS_SQLA_LISTENERS": True,
"LISTVIEWS_DEFAULT_CARD_VIEW": True,
}
```
### Expected results
Expect Plugins to appear in Settings menu, section Manage.
### Actual results
No entry in the menu.
#### Screenshots
#### How to reproduce the bug
1. Create `superset_config.py` with the feature flags and include it in `PYTHONPATH`.
2. `superset run -p 8088 --with-threads --reload --debugger` in one window
3. `npm run dev-server --superset=http://localhost:8088` from `/superset-frontend` in another window
4. Login and click on Settings to verify no change
### Environment
(please complete the following information):
- superset version: 0.999.0dev
- python version: 3.8.7
- node.js version: v14.16.0
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] krsnik93 commented on issue #14373: Custom plugins entry not visible in settings menu after enabling feature flag
Posted by GitBox <gi...@apache.org>.
krsnik93 commented on issue #14373:
URL: https://github.com/apache/superset/issues/14373#issuecomment-828216691
@junlincc not a huge blocker, but wanted to verify it's a real issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on issue #14373: Custom plugins entry not visible in settings menu after enabling feature flag
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #14373:
URL: https://github.com/apache/superset/issues/14373#issuecomment-828147963
@krsnik93 thanks for reporting, do you consider it as a blocker for the project?
@suddjian I don't think we added an entry point to the menu before right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] krsnik93 closed issue #14373: Custom plugins entry not visible in settings menu after enabling feature flag
Posted by GitBox <gi...@apache.org>.
krsnik93 closed issue #14373:
URL: https://github.com/apache/superset/issues/14373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #14373: Custom plugins entry not visible in settings menu after enabling feature flag
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #14373:
URL: https://github.com/apache/superset/issues/14373#issuecomment-828147963
@krsnik93 thanks for reporting, do you consider it as a blocker for the project?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] krsnik93 commented on issue #14373: Custom plugins entry not visible in settings menu after enabling feature flag
Posted by GitBox <gi...@apache.org>.
krsnik93 commented on issue #14373:
URL: https://github.com/apache/superset/issues/14373#issuecomment-828339187
Resolved, a `superset init` after setting the flag was needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org