You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by da...@apache.org on 2015/06/17 12:08:46 UTC
git commit: updated refs/heads/master to a2129b2
Repository: cloudstack
Updated Branches:
refs/heads/master d056c3d27 -> a2129b294
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in VmWorkJobDispatcher.java Assert isn't used in prod runtime, null is properly checked in method
Signed-off-by: Daan Hoogland <da...@gmail.com>
This closes #446
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/a2129b29
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/a2129b29
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/a2129b29
Branch: refs/heads/master
Commit: a2129b29409faaa8609a40784d83cea97e1302ff
Parents: d056c3d
Author: Rafael da Fonseca <rs...@gmail.com>
Authored: Sun Jun 14 21:25:35 2015 +0200
Committer: Daan Hoogland <da...@gmail.com>
Committed: Wed Jun 17 12:08:19 2015 +0200
----------------------------------------------------------------------
engine/orchestration/src/com/cloud/vm/VmWorkJobDispatcher.java | 1 -
1 file changed, 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/a2129b29/engine/orchestration/src/com/cloud/vm/VmWorkJobDispatcher.java
----------------------------------------------------------------------
diff --git a/engine/orchestration/src/com/cloud/vm/VmWorkJobDispatcher.java b/engine/orchestration/src/com/cloud/vm/VmWorkJobDispatcher.java
index bbbf7fd..9f1eca6 100644
--- a/engine/orchestration/src/com/cloud/vm/VmWorkJobDispatcher.java
+++ b/engine/orchestration/src/com/cloud/vm/VmWorkJobDispatcher.java
@@ -71,7 +71,6 @@ public class VmWorkJobDispatcher extends AdapterBase implements AsyncJobDispatch
}
work = VmWorkSerializer.deserialize(workClz, job.getCmdInfo());
- assert(work != null);
if(work == null) {
s_logger.error("Unable to deserialize VM work " + job.getCmd() + ", job info: " + job.getCmdInfo() + ", job origin: " + job.getRelated());
_asyncJobMgr.completeAsyncJob(job.getId(), JobInfo.Status.FAILED, 0, "Unable to deserialize VM work");