You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "Marton Elek (Jira)" <ji...@apache.org> on 2021/02/09 09:44:00 UTC
[jira] [Resolved] (HDDS-4734) Check if state changes in
PipelineStateMap and ContainerStateMap
[ https://issues.apache.org/jira/browse/HDDS-4734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marton Elek resolved HDDS-4734.
-------------------------------
Fix Version/s: 1.1.0
Resolution: Fixed
> Check if state changes in PipelineStateMap and ContainerStateMap
> ----------------------------------------------------------------
>
> Key: HDDS-4734
> URL: https://issues.apache.org/jira/browse/HDDS-4734
> Project: Apache Ozone
> Issue Type: Improvement
> Reporter: Janus Chow
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.1.0
>
>
> The function of PipelineStateMap.updatePipelineState will update the pipeline's state according to the new state in the parameter.
> There is a chance that the new state is the same, say for Pipeline A, the old state is OPEN, and the caller is updating the state of Pipeline A to OPEN again, the direct impact is that _query2Openpipelines_ will add two Pipeline A for the same query.
> Or the differential control of the state is controlled by the higher level invoker, that the caller will always update a different state for a pipeline.
> Besides, in ContainerStateMap, we can check if the state changes too.
> I think it would be better to add a validator here that if the state is not changed, we return directly. It may be inefficient for the deeper layer to always trust the higher layer to send the right parameters.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org