You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/09/11 06:19:51 UTC
[GitHub] [yunikorn-k8shim] 0yukali0 opened a new pull request, #463: [YUNIKORN-1266] Add some examples related to app placement rules
0yukali0 opened a new pull request, #463:
URL: https://github.com/apache/yunikorn-k8shim/pull/463
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - http://yunikorn.apache.org/community/how_to_contribute
### What type of PR is it?
* [ ] - Bug Fix
* [x] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1266
### How should this be tested?
1. Deploy these yaml files and the configuration is changed according to the different example.
2. The log message in yunikorn-scheduler-k8s container is showed by `kubectl logs` command
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] 0yukali0 commented on pull request #463: [YUNIKORN-1266] Add some examples related to app placement rules
Posted by GitBox <gi...@apache.org>.
0yukali0 commented on PR #463:
URL: https://github.com/apache/yunikorn-k8shim/pull/463#issuecomment-1248913391
Hi @wilfred-s, should I added some tests to the dispatcher and how do I know which test i could improve?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] 0yukali0 commented on pull request #463: [YUNIKORN-1266] Add some examples related to app placement rules
Posted by GitBox <gi...@apache.org>.
0yukali0 commented on PR #463:
URL: https://github.com/apache/yunikorn-k8shim/pull/463#issuecomment-1242900913
@wilfred-s Understood.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #463: [YUNIKORN-1266] Add some examples related to app placement rules
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #463:
URL: https://github.com/apache/yunikorn-k8shim/pull/463#issuecomment-1244836774
# [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/463?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#463](https://codecov.io/gh/apache/yunikorn-k8shim/pull/463?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (12f0cb0) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/1f050c40396513b0b60eec87c6b10b0647fcfbc7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1f050c4) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #463 +/- ##
==========================================
- Coverage 67.00% 66.97% -0.03%
==========================================
Files 41 41
Lines 6767 6767
==========================================
- Hits 4534 4532 -2
- Misses 2062 2064 +2
Partials 171 171
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-k8shim/pull/463?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/dispatcher/dispatcher.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/463/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2Rpc3BhdGNoZXIvZGlzcGF0Y2hlci5nbw==) | `74.82% <0.00%> (-1.40%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] 0yukali0 commented on pull request #463: [YUNIKORN-1266] Add some examples related to app placement rules
Posted by GitBox <gi...@apache.org>.
0yukali0 commented on PR #463:
URL: https://github.com/apache/yunikorn-k8shim/pull/463#issuecomment-1260597860
Understood.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] wilfred-s closed pull request #463: [YUNIKORN-1266] Add some examples related to app placement rules
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #463: [YUNIKORN-1266] Add some examples related to app placement rules
URL: https://github.com/apache/yunikorn-k8shim/pull/463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org