[GitHub] [incubator-pekko] mdedetrich commented on pull request #173: Simplify location of protobuf legal license files

["mdedetrich (via GitHub)" <gi...@apache.org>]

mdedetrich commented on PR #173:
URL: https://github.com/apache/incubator-pekko/pull/173#issuecomment-1427072190

   > I am not all sure about this change. I woul be against changing the git root dir license, notice, disclaimer. Our git repo itself can be viewed as akin to a source release. We do need to add distinct licenses into some jars. I don't mind where they are in git as long as the jar is built ok.
   
   > It is an ASF norm to have the source distribution LICENSE git root.
   
   These 2 sentences seem to contradict eachother? Incase its not clear, this PR does not change the resulting jar's in any way. All it is re-arranges where the license files are stored in the git repo.
   
   Also there is a `LICENSE` file in the root, thats not being changed (its actually the same standard LICENSE that is included in the source package and in every other pekko module). The issue right now is that the LICENSE file in the root dir is an exceptional one that is only used for certain maven artifacts (i.e. the protobuff ones).
   
   I don't know if its intentional to use the protobuff specific exclusion for the root `LICENSE` file, but thats how it is right now. If this is intentional then it should be documented because right now its extremely confusing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org