[jira] [Commented] (MAPREDUCE-6395) Improve the commit failure messages in MRAppMaster recovery

["Brahma Reddy Battula (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14583766#comment-14583766 ] 

Brahma Reddy Battula commented on MAPREDUCE-6395:
-------------------------------------------------

[~jira.shegalov] thanks for reporting..

Thinking fix like following, let me know your opinion..

changes  s/we/MRAppMaster/  durring/during
{code}
if (commitSuccess) {
          shutDownMessage = "MRAppMaster crashed after successfully committing. Recovering.";
          forcedState = JobStateInternal.SUCCEEDED;
        } else if (commitFailure) {
          shutDownMessage = "MRAppMaster crashed after a commit failure.";
          forcedState = JobStateInternal.FAILED;
        } else {
          //The commit is still pending, commit error
          shutDownMessage = "MRAppMaster crashed during a commit";
          forcedState = JobStateInternal.ERROR;
        }
{code}
Apart from the mentioned following also going to change..Here I want to remove "we are"
{code}
 if (((JobImpl)job).getInternalState() != JobStateInternal.REBOOT) {
          LOG.info("We are finishing cleanly so this is the last retry");
          isLastAMRetry = true;
        }
{code}

> Improve the commit failure messages in MRAppMaster recovery
> -----------------------------------------------------------
>
>                 Key: MAPREDUCE-6395
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6395
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: applicationmaster
>    Affects Versions: 2.7.0
>            Reporter: Gera Shegalov
>            Assignee: Brahma Reddy Battula
>              Labels: noob
>
> There are typos, and pluralis majestatis (royal we) or user-including "we" messages that are confusing to the users:
> {code}
>         if (commitSuccess) {
>           shutDownMessage = "We crashed after successfully committing. Recovering.";
>           forcedState = JobStateInternal.SUCCEEDED;
>         } else if (commitFailure) {
>           shutDownMessage = "We crashed after a commit failure.";
>           forcedState = JobStateInternal.FAILED;
>         } else {
>           //The commit is still pending, commit error
>           shutDownMessage = "We crashed durring a commit";
>           forcedState = JobStateInternal.ERROR;
>         }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)