You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mod_python-commits@quetz.apache.org by gr...@apache.org on 2006/05/09 05:30:58 UTC

svn commit: r405290 - /httpd/mod_python/trunk/src/mod_python.c

Author: grahamd
Date: Mon May  8 20:30:57 2006
New Revision: 405290

URL: http://svn.apache.org/viewcvs?rev=405290&view=rev
Log:
Old variable definition not removed and was hiding function parameter. If
variable definition attained a non null value, code could also crash. In
worst case, if neither handler or filter specified, result would have been
value of PythonInterpPerDirective setting. The latter shouldn't in practice
occur but cater for it anyway. (MODPYTHON-103)


Modified:
    httpd/mod_python/trunk/src/mod_python.c

Modified: httpd/mod_python/trunk/src/mod_python.c
URL: http://svn.apache.org/viewcvs/httpd/mod_python/trunk/src/mod_python.c?rev=405290&r1=405289&r2=405290&view=diff
==============================================================================
--- httpd/mod_python/trunk/src/mod_python.c (original)
+++ httpd/mod_python/trunk/src/mod_python.c Mon May  8 20:30:57 2006
@@ -1260,13 +1260,14 @@
              * global interpreter.
              */
             
-            py_handler *fh;
-
             if (fh) {
                 s = fh->directory;
             }
             else if (hle) {
                 s = hle->directory;
+            }
+            else {
+                return NULL;
             }
 
             if (s && (s[0] == '\0'))