You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "xuzifu666 (via GitHub)" <gi...@apache.org> on 2024/05/10 01:55:19 UTC

Re: [PR] [SPARK-48219][CORE] StreamReader Charset fix with UTF8 [spark]

xuzifu666 commented on PR #46509:
URL: https://github.com/apache/spark/pull/46509#issuecomment-2103709532

   > Do you think you can provide a test coverage to protect your contribution from potential future regression, @xuzifu666 ?
   > 
   > > Not need
   
   @dongjoon-hyun Thanks for you attentions,In my option this code change not need to provide tests for it's a specification for ReadStream usage,if not set utf8 charset may occur error when system default charset not contains Chinese Chars. You can refer it in other framework such as Calcite,Hive,all set utf8 when this method be called.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org