You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2019/12/20 13:33:18 UTC
[GitHub] [hbase] BukrosSzabolcs opened a new pull request #956: HBASE-23601:
OutputSink.WriterThread exception gets stuck and repeated indefinietly
BukrosSzabolcs opened a new pull request #956: HBASE-23601: OutputSink.WriterThread exception gets stuck and repeated indefinietly
URL: https://github.com/apache/hbase/pull/956
clear exception after logged
try to restart writer threads if needed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #956:
HBASE-23601: OutputSink.WriterThread exception gets stuck and repeated
indefinietly
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #956: HBASE-23601: OutputSink.WriterThread exception gets stuck and repeated indefinietly
URL: https://github.com/apache/hbase/pull/956#discussion_r360487054
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/OutputSink.java
##########
@@ -91,6 +91,15 @@ public synchronized void startWriterThreads() {
}
}
+ public synchronized void restartWriterThreadsIfNeeded() {
+ for (WriterThread t : writerThreads) {
+ if (!t.isAlive()){
+ LOG.debug("restarting thread" + t);
+ t.start();
Review comment:
I didn't think you could restart a dead thread. You have to create a new one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #956: HBASE-23601:
OutputSink.WriterThread exception gets stuck and repeated indefinietly
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #956: HBASE-23601: OutputSink.WriterThread exception gets stuck and repeated indefinietly
URL: https://github.com/apache/hbase/pull/956#issuecomment-571211377
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 39s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ branch-2.2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 15s | branch-2.2 passed |
| +1 :green_heart: | compile | 0m 54s | branch-2.2 passed |
| +1 :green_heart: | checkstyle | 1m 20s | branch-2.2 passed |
| +1 :green_heart: | shadedjars | 4m 9s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 35s | branch-2.2 passed |
| +0 :ok: | spotbugs | 3m 3s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 3m 2s | branch-2.2 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 46s | the patch passed |
| +1 :green_heart: | compile | 0m 57s | the patch passed |
| +1 :green_heart: | javac | 0m 57s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 17s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 4m 3s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 14m 57s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 0m 33s | the patch passed |
| +1 :green_heart: | findbugs | 3m 23s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 151m 24s | hbase-server in the patch passed. |
| +1 :green_heart: | asflicense | 0m 30s | The patch does not generate ASF License warnings. |
| | | 204m 0s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-956/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/956 |
| JIRA Issue | HBASE-23601 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 882e4cb2ce67 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-956/out/precommit/personality/provided.sh |
| git revision | branch-2.2 / aa07d0a25a |
| Default Java | 1.8.0_181 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-956/3/testReport/ |
| Max. process+thread count | 4420 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-956/3/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #956: HBASE-23601:
OutputSink.WriterThread exception gets stuck and repeated indefinietly
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #956: HBASE-23601: OutputSink.WriterThread exception gets stuck and repeated indefinietly
URL: https://github.com/apache/hbase/pull/956#issuecomment-568005722
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 37s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ branch-2.2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 13s | branch-2.2 passed |
| +1 :green_heart: | compile | 0m 56s | branch-2.2 passed |
| +1 :green_heart: | checkstyle | 1m 18s | branch-2.2 passed |
| +1 :green_heart: | shadedjars | 4m 3s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 36s | branch-2.2 passed |
| +0 :ok: | spotbugs | 3m 11s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 3m 10s | branch-2.2 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 42s | the patch passed |
| +1 :green_heart: | compile | 0m 56s | the patch passed |
| +1 :green_heart: | javac | 0m 56s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 18s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 4m 4s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 14m 57s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 0m 35s | the patch passed |
| +1 :green_heart: | findbugs | 3m 19s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 162m 5s | hbase-server in the patch passed. |
| +1 :green_heart: | asflicense | 0m 34s | The patch does not generate ASF License warnings. |
| | | 214m 26s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-956/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/956 |
| JIRA Issue | HBASE-23601 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux f429b7fb81ec 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-956/out/precommit/personality/provided.sh |
| git revision | branch-2.2 / 5ec99b4f10 |
| Default Java | 1.8.0_181 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-956/1/testReport/ |
| Max. process+thread count | 4984 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-956/1/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #956:
HBASE-23601: OutputSink.WriterThread exception gets stuck and repeated
indefinietly
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #956: HBASE-23601: OutputSink.WriterThread exception gets stuck and repeated indefinietly
URL: https://github.com/apache/hbase/pull/956#discussion_r360489711
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java
##########
@@ -478,6 +478,10 @@ void checkForErrors() throws IOException {
throw new RuntimeException(thrown);
}
}
+
+ public Throwable clearError(){
+ return thrown.getAndSet(null);
+ }
Review comment:
I see we make the pipelinecontroller once and use it thereafter -- it goes down into the WriterThread.... . I was going to suggest just create a new Controller on each write but looks like too much of a refactor.
Would it be cleaner if checkForErrors cleared any errors found... ; i.e. checkForErrors throws but before it throws it clears any exception in Controller?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack merged pull request #956: HBASE-23601:
OutputSink.WriterThread exception gets stuck and repeated indefinietly
Posted by GitBox <gi...@apache.org>.
saintstack merged pull request #956: HBASE-23601: OutputSink.WriterThread exception gets stuck and repeated indefinietly
URL: https://github.com/apache/hbase/pull/956
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] BukrosSzabolcs commented on a change in pull request #956:
HBASE-23601: OutputSink.WriterThread exception gets stuck and repeated
indefinietly
Posted by GitBox <gi...@apache.org>.
BukrosSzabolcs commented on a change in pull request #956: HBASE-23601: OutputSink.WriterThread exception gets stuck and repeated indefinietly
URL: https://github.com/apache/hbase/pull/956#discussion_r362806887
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java
##########
@@ -478,6 +478,10 @@ void checkForErrors() throws IOException {
throw new RuntimeException(thrown);
}
}
+
+ public Throwable clearError(){
+ return thrown.getAndSet(null);
+ }
Review comment:
Not just cleaner it would also cover more usecases. I moved that line into the checkForErrors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] BukrosSzabolcs commented on issue #956: HBASE-23601:
OutputSink.WriterThread exception gets stuck and repeated indefinietly
Posted by GitBox <gi...@apache.org>.
BukrosSzabolcs commented on issue #956: HBASE-23601: OutputSink.WriterThread exception gets stuck and repeated indefinietly
URL: https://github.com/apache/hbase/pull/956#issuecomment-570572733
@wchevreuil > Is it possible to add a test that reproduces the problem?
Added a small test. Please let me know if you had something else in mind.
@HorizonNet > Does this problem only occur in HBase 2.2.x? If not it would be better to target the master branch.
Duo re-wrote most of the region replication on master so it should only affect branch-2 and branch-2.2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #956:
HBASE-23601: OutputSink.WriterThread exception gets stuck and repeated
indefinietly
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #956: HBASE-23601: OutputSink.WriterThread exception gets stuck and repeated indefinietly
URL: https://github.com/apache/hbase/pull/956#discussion_r362903238
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/OutputSink.java
##########
@@ -194,6 +215,14 @@ public boolean flush() throws IOException {
outputSink = sink;
}
+ WriterThread(WALSplitter.PipelineController controller, EntryBuffers entryBuffers,
+ OutputSink sink, String threadName) {
+ super(threadName);
+ this.controller = controller;
+ this.entryBuffers = entryBuffers;
+ outputSink = sink;
+ }
+
Review comment:
Have the constructor just above this call this one passing the constructed thread name? nit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] BukrosSzabolcs commented on a change in pull request #956:
HBASE-23601: OutputSink.WriterThread exception gets stuck and repeated
indefinietly
Posted by GitBox <gi...@apache.org>.
BukrosSzabolcs commented on a change in pull request #956: HBASE-23601: OutputSink.WriterThread exception gets stuck and repeated indefinietly
URL: https://github.com/apache/hbase/pull/956#discussion_r362805861
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/OutputSink.java
##########
@@ -91,6 +91,15 @@ public synchronized void startWriterThreads() {
}
}
+ public synchronized void restartWriterThreadsIfNeeded() {
+ for (WriterThread t : writerThreads) {
+ if (!t.isAlive()){
+ LOG.debug("restarting thread" + t);
+ t.start();
Review comment:
You are absolutely. Thanks for pointing it out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #956:
HBASE-23601: OutputSink.WriterThread exception gets stuck and repeated
indefinietly
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #956: HBASE-23601: OutputSink.WriterThread exception gets stuck and repeated indefinietly
URL: https://github.com/apache/hbase/pull/956#discussion_r362901505
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/OutputSink.java
##########
@@ -91,6 +93,25 @@ public synchronized void startWriterThreads() {
}
}
+ public synchronized void restartWriterThreadsIfNeeded() {
+ Iterator<WriterThread> writerIterator = writerThreads.iterator();
+ //remove dead threads
+ List<String> names = new ArrayList();
+ while(writerIterator.hasNext()){
+ WriterThread t = writerIterator.next();
+ if (!t.isAlive()){
+ names.add(t.getName());
Review comment:
Would it be easier to move through the writerThread array using an index replacing dead threads with new live ones as you go? Should log when you replace a thread I'd say at DEBUG level?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] BukrosSzabolcs commented on issue #956: HBASE-23601:
OutputSink.WriterThread exception gets stuck and repeated indefinietly
Posted by GitBox <gi...@apache.org>.
BukrosSzabolcs commented on issue #956: HBASE-23601: OutputSink.WriterThread exception gets stuck and repeated indefinietly
URL: https://github.com/apache/hbase/pull/956#issuecomment-573630744
created a new PR for branch-2 #1028
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #956: HBASE-23601:
OutputSink.WriterThread exception gets stuck and repeated indefinietly
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #956: HBASE-23601: OutputSink.WriterThread exception gets stuck and repeated indefinietly
URL: https://github.com/apache/hbase/pull/956#issuecomment-570626718
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 37s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ branch-2.2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 15s | branch-2.2 passed |
| +1 :green_heart: | compile | 0m 55s | branch-2.2 passed |
| +1 :green_heart: | checkstyle | 1m 19s | branch-2.2 passed |
| +1 :green_heart: | shadedjars | 4m 1s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 36s | branch-2.2 passed |
| +0 :ok: | spotbugs | 3m 9s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 3m 7s | branch-2.2 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 46s | the patch passed |
| +1 :green_heart: | compile | 0m 55s | the patch passed |
| +1 :green_heart: | javac | 0m 55s | the patch passed |
| -1 :x: | checkstyle | 1m 17s | hbase-server: The patch generated 19 new + 3 unchanged - 0 fixed = 22 total (was 3) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | shadedjars | 3m 15s | patch has 10 errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 15m 0s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 0m 33s | the patch passed |
| +1 :green_heart: | findbugs | 3m 11s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 144m 16s | hbase-server in the patch passed. |
| -1 :x: | asflicense | 0m 30s | The patch generated 1 ASF License warnings. |
| | | 195m 48s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-956/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/956 |
| JIRA Issue | HBASE-23601 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 514341326d81 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-956/out/precommit/personality/provided.sh |
| git revision | branch-2.2 / 8d22b7ee11 |
| Default Java | 1.8.0_181 |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-956/2/artifact/out/diff-checkstyle-hbase-server.txt |
| shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-956/2/artifact/out/patch-shadedjars.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-956/2/testReport/ |
| asflicense | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-956/2/artifact/out/patch-asflicense-problems.txt |
| Max. process+thread count | 4065 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-956/2/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] BukrosSzabolcs commented on a change in pull request #956:
HBASE-23601: OutputSink.WriterThread exception gets stuck and repeated
indefinietly
Posted by GitBox <gi...@apache.org>.
BukrosSzabolcs commented on a change in pull request #956: HBASE-23601: OutputSink.WriterThread exception gets stuck and repeated indefinietly
URL: https://github.com/apache/hbase/pull/956#discussion_r363285463
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/OutputSink.java
##########
@@ -91,6 +93,25 @@ public synchronized void startWriterThreads() {
}
}
+ public synchronized void restartWriterThreadsIfNeeded() {
+ Iterator<WriterThread> writerIterator = writerThreads.iterator();
+ //remove dead threads
+ List<String> names = new ArrayList();
+ while(writerIterator.hasNext()){
+ WriterThread t = writerIterator.next();
+ if (!t.isAlive()){
+ names.add(t.getName());
Review comment:
Thanks for the suggestion. Added it to the next commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] BukrosSzabolcs commented on a change in pull request #956:
HBASE-23601: OutputSink.WriterThread exception gets stuck and repeated
indefinietly
Posted by GitBox <gi...@apache.org>.
BukrosSzabolcs commented on a change in pull request #956: HBASE-23601: OutputSink.WriterThread exception gets stuck and repeated indefinietly
URL: https://github.com/apache/hbase/pull/956#discussion_r363285252
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/OutputSink.java
##########
@@ -194,6 +215,14 @@ public boolean flush() throws IOException {
outputSink = sink;
}
+ WriterThread(WALSplitter.PipelineController controller, EntryBuffers entryBuffers,
+ OutputSink sink, String threadName) {
+ super(threadName);
+ this.controller = controller;
+ this.entryBuffers = entryBuffers;
+ outputSink = sink;
+ }
+
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services