You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by hu...@apache.org on 2023/07/07 17:08:34 UTC

[superset] branch master updated: fix: change naming convention for count metric on Dataset creation (#24609)

This is an automated email from the ASF dual-hosted git repository.

hugh pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new c573cfcd12 fix: change naming convention for count metric on Dataset creation (#24609)
c573cfcd12 is described below

commit c573cfcd120528a6c65e75ce23ba77fdf9fb8c16
Author: Hugh A. Miles II <hu...@gmail.com>
AuthorDate: Fri Jul 7 13:08:27 2023 -0400

    fix: change naming convention for count metric on Dataset creation (#24609)
---
 superset/datasets/commands/create.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset/datasets/commands/create.py b/superset/datasets/commands/create.py
index 38b8bf4363..6349aa6bdb 100644
--- a/superset/datasets/commands/create.py
+++ b/superset/datasets/commands/create.py
@@ -48,7 +48,7 @@ class CreateDatasetCommand(CreateMixin, BaseCommand):
             dataset = DatasetDAO.create(self._properties, commit=False)
 
             # Updates columns and metrics from the dataset
-            dataset.metrics = [SqlMetric(metric_name="count", expression="COUNT(*)")]
+            dataset.metrics = [SqlMetric(metric_name="COUNT(*)", expression="COUNT(*)")]
 
             dataset.fetch_metadata(commit=False)
             db.session.commit()