[GitHub] [superset] zhaoyongjie commented on a change in pull request #13330: fix: date picker support date unit with singular and plural

[GitBox <gi...@apache.org>]

zhaoyongjie commented on a change in pull request #13330:
URL: https://github.com/apache/superset/pull/13330#discussion_r582624277



##########
File path: tests/utils/date_parser_tests.py
##########
@@ -88,10 +88,18 @@ def test_get_since_until(self):
         expected = datetime(2016, 6, 7), datetime(2016, 11, 7)
         self.assertEqual(result, expected)
 
+        result = get_since_until("Last 5 month")
+        expected = datetime(2016, 6, 7), datetime(2016, 11, 7)
+        self.assertEqual(result, expected)
+

Review comment:
       thanks for reminding me.  Because there is `Last 5 months` UT case now, so added a `Last 5 month`(This syntax is wrong )




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org