You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/05 13:42:47 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #27808: [SPARK-30994][BUILD][FOLLOW-UP] Change scope of xml-apis to include it

HyukjinKwon commented on a change in pull request #27808: [SPARK-30994][BUILD][FOLLOW-UP] Change scope of xml-apis to include it
URL: https://github.com/apache/spark/pull/27808#discussion_r388298985
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -612,7 +612,6 @@
         <groupId>xml-apis</groupId>
         <artifactId>xml-apis</artifactId>
         <version>1.4.01</version>
-        <scope>test</scope>
 
 Review comment:
   @srowen, I was wondering this actually overrides the scope of `xml-apis`, forces to be present in `test` scope only, and make it not present in the build output.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org