You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@incubator.apache.org by Wei-1 <gi...@git.apache.org> on 2018/12/07 07:46:50 UTC
[GitHub] apache-website-template pull request #10: [Bug] Download Link Update
GitHub user Wei-1 opened a pull request:
https://github.com/apache/apache-website-template/pull/10
[Bug] Download Link Update
The download-page is actually a Markdown file.
with `.html` it will point to 404
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Wei-1/apache-website-template patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/apache-website-template/pull/10.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10
----
commit 96d68ab24159efdf5f4c1da273450e082d3b621c
Author: Wei Chen <we...@...>
Date: 2018-12-07T07:46:26Z
[Bug] Download Link Update
The download-page is actually a Markdown file.
with `.html` it will point to 404
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: cvs-unsubscribe@incubator.apache.org
For additional commands, e-mail: cvs-help@incubator.apache.org
[GitHub] apache-website-template issue #10: [Bug] Download Link Update
Posted by julianhyde <gi...@git.apache.org>.
Github user julianhyde commented on the issue:
https://github.com/apache/apache-website-template/pull/10
I have reviewed and staged in my own branch https://github.com/julianhyde/apache-website-template/commits/master but I don't think I have rights to commit. @justinmclean @stain @lresende can one of you commit my master branch (2 of my commits plus one from @Wei-1.)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: cvs-unsubscribe@incubator.apache.org
For additional commands, e-mail: cvs-help@incubator.apache.org
[GitHub] apache-website-template issue #10: [Bug] Download Link Update
Posted by Wei-1 <gi...@git.apache.org>.
Github user Wei-1 commented on the issue:
https://github.com/apache/apache-website-template/pull/10
I simply follow the guide in the `README.md`.
and after `bundle exec jekyll serve`, I didn't see download.html get generated.
After accessing the web on `localhost:4000` and click `Get SystemML`,
one will see a `NOT FOUND, '/download.html' not found.` page.
Can you help to check this? @julianhyde
---
---------------------------------------------------------------------
To unsubscribe, e-mail: cvs-unsubscribe@incubator.apache.org
For additional commands, e-mail: cvs-help@incubator.apache.org
[GitHub] apache-website-template issue #10: [Bug] Download Link Update
Posted by julianhyde <gi...@git.apache.org>.
Github user julianhyde commented on the issue:
https://github.com/apache/apache-website-template/pull/10
I'm not sure about this. After jekyll has generated the downloads page, its path will be `download.html`, right? On some web servers you can reference as `download` but `download.html` is the safest.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: cvs-unsubscribe@incubator.apache.org
For additional commands, e-mail: cvs-help@incubator.apache.org
[GitHub] apache-website-template pull request #10: [Bug] Download Link Update
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/apache-website-template/pull/10
---
---------------------------------------------------------------------
To unsubscribe, e-mail: cvs-unsubscribe@incubator.apache.org
For additional commands, e-mail: cvs-help@incubator.apache.org