You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by pengjianhua <pe...@zte.com.cn> on 2017/09/13 08:53:20 UTC

Re: Review Request 62269: The Ranger can not refresh screen and hide child menu when user clicks menu

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62269/
-----------------------------------------------------------

(Updated 九月 13, 2017, 8:53 a.m.)


Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.


Summary (updated)
-----------------

The Ranger can not refresh screen and hide child menu when user clicks menu


Bugs: RANGER-1777
    https://issues.apache.org/jira/browse/RANGER-1777


Repository: ranger


Description (updated)
-------

Like https://issues.apache.org/jira/projects/RANGER, related web screen will be refresh and child menu will be hided when user clicked menu. But Ranger can not refresh screen and hide child menu.
At most web-menu-button ,such as https://issues.apache.org/jira/projects/RANGER, the sub-memu-buttons should be hide when you click menu.(see normal.jpg).
When you click "Access Manage" or "Settings" menu, the sub-memu-buttons is not hide(see ranger-not-hide.jpg) in Ranger. 
We should modify the control logic of Ranger menu to keep consistent with https://issues.apache.org/jira/projects/RANGER.


Diffs
-----

  security-admin/src/main/webapp/scripts/views/common/TopNav.js bc5d17c4 


Diff: https://reviews.apache.org/r/62269/diff/1/


Testing
-------


Thanks,

pengjianhua


Re: Review Request 62269: The Ranger can not refresh screen and hide child menu when user clicks menu

Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62269/#review185387
-----------------------------------------------------------


Ship it!




Ship It!

- Colm O hEigeartaigh


On Sept. 13, 2017, 8:53 a.m., pengjianhua wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62269/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2017, 8:53 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1777
>     https://issues.apache.org/jira/browse/RANGER-1777
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Like https://issues.apache.org/jira/projects/RANGER, related web screen will be refresh and child menu will be hided when user clicked menu. But Ranger can not refresh screen and hide child menu.
> At most web-menu-button ,such as https://issues.apache.org/jira/projects/RANGER, the sub-memu-buttons should be hide when you click menu.(see normal.jpg).
> When you click "Access Manage" or "Settings" menu, the sub-memu-buttons is not hide(see ranger-not-hide.jpg) in Ranger. 
> We should modify the control logic of Ranger menu to keep consistent with https://issues.apache.org/jira/projects/RANGER.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/scripts/views/common/TopNav.js bc5d17c4 
> 
> 
> Diff: https://reviews.apache.org/r/62269/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengjianhua
> 
>