You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/09/29 01:59:15 UTC
[GitHub] [cloudstack] utchoang opened a new pull request #5526: UI - Fixes modal width by device screen
utchoang opened a new pull request #5526:
URL: https://github.com/apache/cloudstack/pull/5526
### Description
Fixes https://github.com/apache/cloudstack/issues/5524
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
After fixes:
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5526: UI - Fixes modal width by device screen
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5526:
URL: https://github.com/apache/cloudstack/pull/5526#issuecomment-930342311
@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5526: UI - Fixes modal width by device screen
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5526:
URL: https://github.com/apache/cloudstack/pull/5526#issuecomment-930341871
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5526: UI - Fixes modal width by device screen
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5526:
URL: https://github.com/apache/cloudstack/pull/5526#issuecomment-930345804
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5526 (SL-JID-711)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd edited a comment on pull request #5526: UI - Fixes modal width by device screen
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on pull request #5526:
URL: https://github.com/apache/cloudstack/pull/5526#issuecomment-929819620
@utchoang lgtm on my phone, I'll need to test a few more screen sizes. The reboot VM button on mobile for me doesn't work, can you check that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang edited a comment on pull request #5526: UI - Fixes modal width by device screen
Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on pull request #5526:
URL: https://github.com/apache/cloudstack/pull/5526#issuecomment-929864192
> @utchoang lgtm on my phone, I'll need to test a few more screen sizes. The reboot VM button on mobile for me doesn't work, can you check that?
As far as I found this error comes from the Api `rebootVirtualMachine` no longer having the `force` parameter. Is it ok if I remove force field from the reboot form?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang edited a comment on pull request #5526: UI - Fixes modal width by device screen
Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on pull request #5526:
URL: https://github.com/apache/cloudstack/pull/5526#issuecomment-929864192
> @utchoang lgtm on my phone, I'll need to test a few more screen sizes. The reboot VM button on mobile for me doesn't work, can you check that?
As far as I found this error comes from the Api `rebootVirtualMachine` no longer having the `force` parameter. Is it ok if I remove force field from the reboot form?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #5526: UI - Fixes modal width by device screen
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #5526:
URL: https://github.com/apache/cloudstack/pull/5526
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5526: UI - Fixes modal width by device screen
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5526:
URL: https://github.com/apache/cloudstack/pull/5526#issuecomment-929819620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5526: UI - Fixes modal width by device screen
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5526:
URL: https://github.com/apache/cloudstack/pull/5526#issuecomment-929759868
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #5526: UI - Fixes modal width by device screen
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #5526:
URL: https://github.com/apache/cloudstack/pull/5526#issuecomment-930913939
Thanks @utchoang, but now the tooltip stays on top of the window after you press the button
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5526: UI - Fixes modal width by device screen
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5526:
URL: https://github.com/apache/cloudstack/pull/5526#issuecomment-930025755
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on a change in pull request #5526: UI - Fixes modal width by device screen
Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #5526:
URL: https://github.com/apache/cloudstack/pull/5526#discussion_r718184183
##########
File path: ui/src/views/AutogenView.vue
##########
@@ -1524,13 +1527,18 @@ export default {
} else {
callback()
}
+ },
+ setModalWidthByScreen () {
+ const screenWidth = window.innerWidth
+ if (screenWidth <= 768) {
+ this.modalWidth = '450px'
Review comment:
No, currently I only hard fix the width for ipad, tablet screens and below. Do you feel it is ok or do you need to follow the percentage of the screen?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5526: UI - Fixes modal width by device screen
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5526:
URL: https://github.com/apache/cloudstack/pull/5526#issuecomment-929953413
Ah okay, no keep it @utchoang I found the forced parameter was added in 4.16 but qa.cloudstack.org server/backend is 4.15.2.0. I'll upgrade its backend to 4.16-snapshot shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5526: UI - Fixes modal width by device screen
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5526:
URL: https://github.com/apache/cloudstack/pull/5526#issuecomment-930115905
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5526: UI - Fixes modal width by device screen
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5526:
URL: https://github.com/apache/cloudstack/pull/5526#issuecomment-929819620
@utchoang lgtm on my phone, Ill
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5526: UI - Fixes modal width by device screen
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5526:
URL: https://github.com/apache/cloudstack/pull/5526#issuecomment-929759032
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #5526: UI - Fixes modal width by device screen
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #5526:
URL: https://github.com/apache/cloudstack/pull/5526#discussion_r718138367
##########
File path: ui/src/views/AutogenView.vue
##########
@@ -1524,13 +1527,18 @@ export default {
} else {
callback()
}
+ },
+ setModalWidthByScreen () {
+ const screenWidth = window.innerWidth
+ if (screenWidth <= 768) {
+ this.modalWidth = '450px'
Review comment:
Should this be like a percentage of total width?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5526: UI - Fixes modal width by device screen
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5526:
URL: https://github.com/apache/cloudstack/pull/5526#issuecomment-929864192
> @utchoang lgtm on my phone, I'll need to test a few more screen sizes. The reboot VM button on mobile for me doesn't work, can you check that?
As far as I found this error comes from the Api `rebootVirtualMachine` no longer having the `force` parameter. Is it ok if I remove it from the reboot form?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd edited a comment on pull request #5526: UI - Fixes modal width by device screen
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on pull request #5526:
URL: https://github.com/apache/cloudstack/pull/5526#issuecomment-929819620
@utchoang lgtm on my phone, I'll need to test a few more screen sizes. The reboot VM button on mobile for me doesn't work, can you check that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on a change in pull request #5526: UI - Fixes modal width by device screen
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #5526:
URL: https://github.com/apache/cloudstack/pull/5526#discussion_r719040693
##########
File path: ui/src/views/AutogenView.vue
##########
@@ -1524,13 +1527,18 @@ export default {
} else {
callback()
}
+ },
+ setModalWidthByScreen () {
+ const screenWidth = window.innerWidth
+ if (screenWidth <= 768) {
+ this.modalWidth = '450px'
Review comment:
I too think percentage will be better. Perhaps 90% ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5526: UI - Fixes modal width by device screen
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5526:
URL: https://github.com/apache/cloudstack/pull/5526#issuecomment-930704051
@rhtyd @borisstoyanov please confirm if your comments have been addressed and if its ready to merge, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5526: UI - Fixes modal width by device screen
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5526:
URL: https://github.com/apache/cloudstack/pull/5526#issuecomment-930026310
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on a change in pull request #5526: UI - Fixes modal width by device screen
Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #5526:
URL: https://github.com/apache/cloudstack/pull/5526#discussion_r718184183
##########
File path: ui/src/views/AutogenView.vue
##########
@@ -1524,13 +1527,18 @@ export default {
} else {
callback()
}
+ },
+ setModalWidthByScreen () {
+ const screenWidth = window.innerWidth
+ if (screenWidth <= 768) {
+ this.modalWidth = '450px'
Review comment:
No, currently I only hard fix the width for ipad, tablet screens and below. Do you feel it is ok or do you need to follow the percentage of the screen?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5526: UI - Fixes modal width by device screen
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5526:
URL: https://github.com/apache/cloudstack/pull/5526#issuecomment-929759032
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #5526: UI - Fixes modal width by device screen
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #5526:
URL: https://github.com/apache/cloudstack/pull/5526
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #5526: UI - Fixes modal width by device screen
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5526:
URL: https://github.com/apache/cloudstack/pull/5526
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5526: UI - Fixes modal width by device screen
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5526:
URL: https://github.com/apache/cloudstack/pull/5526#issuecomment-930029580
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5526 (SL-JID-710)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5526: UI - Fixes modal width by device screen
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5526:
URL: https://github.com/apache/cloudstack/pull/5526#issuecomment-929956037
@utchoang can you check and update/fix the UI unit tests. This is as seen from Travis's job 1:
```
cloudstack-ui@1.0.0 test:unit /home/travis/build/apache/cloudstack/ui
> vue-cli-service test:unit
Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db
[vue-jest]: Less are not currently compiled by vue-jest
FAIL tests/unit/views/AutogenView.spec.js (33.139s)
....
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5526: UI - Fixes modal width by device screen
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5526:
URL: https://github.com/apache/cloudstack/pull/5526#issuecomment-929762081
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5526 (SL-JID-707)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #5526: UI - Fixes modal width by device screen
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #5526:
URL: https://github.com/apache/cloudstack/pull/5526#discussion_r718138367
##########
File path: ui/src/views/AutogenView.vue
##########
@@ -1524,13 +1527,18 @@ export default {
} else {
callback()
}
+ },
+ setModalWidthByScreen () {
+ const screenWidth = window.innerWidth
+ if (screenWidth <= 768) {
+ this.modalWidth = '450px'
Review comment:
Should this be like a percentage of total width?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5526: UI - Fixes modal width by device screen
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5526:
URL: https://github.com/apache/cloudstack/pull/5526#issuecomment-930779820
Tested lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5526: UI - Fixes modal width by device screen
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5526:
URL: https://github.com/apache/cloudstack/pull/5526#issuecomment-930972659
@borisroman In my opinion, it is ant design behavior so blocking it will cause conflict with the tooltip in the web interface. Refer: https://www.antdv.com/components/tooltip/#Tooltip
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5526: UI - Fixes modal width by device screen
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5526:
URL: https://github.com/apache/cloudstack/pull/5526#issuecomment-929759868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org