You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "mridulpathak (via GitHub)" <gi...@apache.org> on 2026/10/03 17:08:03 UTC
[PR] Fixed: Do not evaluate the expand/collapse link of tree widgets as an expression (OFBIZ-13639) [ofbiz-framework]
mridulpathak opened a new pull request, #2191:
URL: https://github.com/apache/ofbiz-framework/pull/2191
Fixed: Do not evaluate the expand/collapse link of tree widgets as an expression (OFBIZ-13639)
Explanation:
When a tree widget has no expand-collapse-request, ModelTree.getExpandCollapseRequest builds the link target from the request URI, and the tree renderers hand it to the ModelTree.ModelNode.Link constructor, which parsed it again as a FlexibleStringExpander, so that request data was evaluated as an expression. The trail parameter that MacroTreeRenderer adds to the link, which also comes from the request, was parsed the same way.
FlexibleStringExpander.getLiteral returns an instance that never parses its text. The Link constructors that take plain strings, used only by the tree renderers, now use it for the style, target and text, and the new CommonWidgetModels.Parameter.literal does the same for the trail parameter. The Link constructor that reads the XML element still evaluates expressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed: Do not evaluate the expand/collapse link of tree widgets as an expression (OFBIZ-13639) [ofbiz-framework]
Posted by "mridulpathak (via GitHub)" <gi...@apache.org>.
mridulpathak merged PR #2191:
URL: https://github.com/apache/ofbiz-framework/pull/2191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org