You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/18 16:11:18 UTC
[GitHub] [spark] felixcheung commented on issue #24388: [SPARK-27481][BUILD]
Upgrade commons-logging to 1.1.3 for hadoop-3.2
felixcheung commented on issue #24388: [SPARK-27481][BUILD] Upgrade commons-logging to 1.1.3 for hadoop-3.2
URL: https://github.com/apache/spark/pull/24388#issuecomment-484576792
hm, then I actually we shouldn't pull this in unconditionally - only if hive 1.x or lower but not higher when it is not needed. this is because we have enough problem with jar conflict and commons-logging could be popular, and it is not shaded here. yes, I understand this is pre-existing but a small little bit helps
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org