You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gobblin.apache.org by hu...@apache.org on 2018/02/26 19:49:44 UTC
incubator-gobblin git commit: [GOBBLIN-416] Add java option for task
child process
Repository: incubator-gobblin
Updated Branches:
refs/heads/master 97e29f436 -> 0d89640cf
[GOBBLIN-416] Add java option for task child process
Closes #2292 from yukuai518/javaopt
Project: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/commit/0d89640c
Tree: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/tree/0d89640c
Diff: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/diff/0d89640c
Branch: refs/heads/master
Commit: 0d89640cfcfbfb14da6ec80f484eae16b5b98eaf
Parents: 97e29f4
Author: Kuai Yu <ku...@linkedin.com>
Authored: Mon Feb 26 11:49:35 2018 -0800
Committer: Hung Tran <hu...@linkedin.com>
Committed: Mon Feb 26 11:49:35 2018 -0800
----------------------------------------------------------------------
.../gobblin/cluster/GobblinClusterConfigurationKeys.java | 2 ++
.../java/org/apache/gobblin/cluster/SingleTaskLauncher.java | 8 ++++++++
2 files changed, 10 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-gobblin/blob/0d89640c/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterConfigurationKeys.java
----------------------------------------------------------------------
diff --git a/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterConfigurationKeys.java b/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterConfigurationKeys.java
index 68a8208..5719b23 100644
--- a/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterConfigurationKeys.java
+++ b/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterConfigurationKeys.java
@@ -37,6 +37,8 @@ public class GobblinClusterConfigurationKeys {
GOBBLIN_CLUSTER_PREFIX + "task.classpath";
public static final String TASK_LOG_CONFIG =
GOBBLIN_CLUSTER_PREFIX + "task.log.config";
+ public static final String TASK_JAVA_OPTIONS =
+ GOBBLIN_CLUSTER_PREFIX + "task.java.options";
// General Gobblin Cluster application configuration properties.
public static final String APPLICATION_NAME_OPTION_NAME = "app_name";
http://git-wip-us.apache.org/repos/asf/incubator-gobblin/blob/0d89640c/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/SingleTaskLauncher.java
----------------------------------------------------------------------
diff --git a/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/SingleTaskLauncher.java b/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/SingleTaskLauncher.java
index e6fac31..078f122 100644
--- a/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/SingleTaskLauncher.java
+++ b/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/SingleTaskLauncher.java
@@ -79,6 +79,7 @@ class SingleTaskLauncher {
List<String> build() {
addJavaBin();
+ addJavaOptions();
addClassPath();
addLogConfig();
addClassName();
@@ -86,6 +87,13 @@ class SingleTaskLauncher {
return this.cmd;
}
+ private void addJavaOptions() {
+ if (sysConfig.hasPath(GobblinClusterConfigurationKeys.TASK_JAVA_OPTIONS)) {
+ final String javaOptions = sysConfig.getString(GobblinClusterConfigurationKeys.TASK_JAVA_OPTIONS);
+ this.cmd.add(javaOptions);
+ }
+ }
+
private void addClassName() {
final String runnerClassName = SingleTaskRunnerMain.class.getCanonicalName();
this.cmd.add(runnerClassName);