You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2017/02/28 22:36:11 UTC
[GitHub] brooklyn-server pull request #576: BundleMaker (part1)
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/576
BundleMaker (part1)
This is extracted from https://github.com/apache/brooklyn-server/pull/485 - it excludes the changes to the REST api; it improves test coverage and fixes a couple of things in `BundleMaker` (generics, and NPE in `createJarFromClasspathDir` when there is no manifest).
The intent is that we can merge this soon, without having to wait for consensus on the REST api changes.
The first commit is a squashing-together of @ahgittin's two commits in https://github.com/apache/brooklyn-server/pull/485, but with the rest-api changes removed. I made no other changes to that commit (hence the author being Alex).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server install-osgi-bundles-part1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/576.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #576
----
commit 33f7940c18ba8cd17fd83500486e02376d3b8fd8
Author: Alex Heneveld <al...@alexs-macbook-pro.local>
Date: 2016-12-12T15:43:50Z
`BundleMaker` utility routines making it easy to add osgi bundles dynamically
and testing things like inserting a manifest and loading files from the bundles
commit 7d1d47b6e8c3ef919d1d52be3d23a5dc036a2d5c
Author: Aled Sage <al...@gmail.com>
Date: 2017-02-28T22:04:35Z
BundleMaker: add tests, and fix
commit f20cdecd2fef5c7ff2f6ef33ab7731c7acfb6de4
Author: Aled Sage <al...@gmail.com>
Date: 2017-02-28T22:26:55Z
CatalogBomScanner tidy
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #576: BundleMaker (part1)
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/576
looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #576: BundleMaker (part1)
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/576
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---