You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/23 19:20:34 UTC
[GitHub] [spark] rxin opened a new pull request, #39197: [MINOR][SQL] Remove redundant comment in CTESubstitution
rxin opened a new pull request, #39197:
URL: https://github.com/apache/spark/pull/39197
### What changes were proposed in this pull request?
I think the proposed removal is just a duplicate of the next point. I actually spent couple minutes trying to understand if there was a difference.
### Why are the changes needed?
See above.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
This is a code comment change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #39197: [MINOR][SQL] Remove redundant comment in CTESubstitution
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #39197:
URL: https://github.com/apache/spark/pull/39197#issuecomment-1364410838
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #39197: [MINOR][SQL] Remove redundant comment in CTESubstitution
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #39197:
URL: https://github.com/apache/spark/pull/39197#issuecomment-1364903151
late LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] rxin commented on pull request #39197: [MINOR][SQL] Remove redundant comment in CTESubstitution
Posted by GitBox <gi...@apache.org>.
rxin commented on PR #39197:
URL: https://github.com/apache/spark/pull/39197#issuecomment-1364263499
cc @maryannxue and @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #39197: [MINOR][SQL] Remove redundant comment in CTESubstitution
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #39197: [MINOR][SQL] Remove redundant comment in CTESubstitution
URL: https://github.com/apache/spark/pull/39197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org