[GitHub] [incubator-kyuubi] wForget commented on a diff in pull request #3048: [KYUUBI #3051] Support to get the real client ip address for thrift connection when using VIP as kyuubi server load balancer

[GitBox <gi...@apache.org>]

wForget commented on code in PR #3048:
URL: https://github.com/apache/incubator-kyuubi/pull/3048#discussion_r964928626


##########
externals/kyuubi-hive-sql-engine/src/main/scala/org/apache/kyuubi/engine/hive/session/HiveSessionImpl.scala:
##########
@@ -33,7 +33,6 @@ class HiveSessionImpl(
     protocol: TProtocolVersion,
     user: String,
     password: String,
-    serverIpAddress: String,

Review Comment:
   [SparkSessionImpl.scala#L51](https://github.com/turboFei/incubator-kyuubi/blob/97f9b00417f211cc547998821ba421b15edb6c76/externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/session/SparkSessionImpl.scala#L51) becomes redundant, thanks, I will remove it.
   
   ```
     def serverIpAddress(): String = serverIpAddress
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org