[jira] [Closed] (FLINK-7489) Remove job lifecycle methods from public JobMasterGateway interface

["Till Rohrmann (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FLINK-7489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Till Rohrmann closed FLINK-7489.
--------------------------------
       Resolution: Fixed
    Fix Version/s: 1.4.0

Fixed via 1fc4a609761445ecf77c374ae9daec8a1ada2618

> Remove job lifecycle methods from public JobMasterGateway interface
> -------------------------------------------------------------------
>
>                 Key: FLINK-7489
>                 URL: https://issues.apache.org/jira/browse/FLINK-7489
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Coordination
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>              Labels: flip-6
>             Fix For: 1.4.0
>
>
> The {{JobMaster}} exposes its job lifecycle methods {{startJobExecution}} and {{suspendExecution}} via its {{JobMasterGateway}} to the public. I think these methods should not be exposed because it allows other components to affect the job execution without proper reason. Only the {{JobManagerRunner}} should be responsible for calling these methods and has direct access to the {{JobMaster}} instance. Therefore, these methods can directly be implemented by the {{JobMaster}} without exposing them via the {{JobMasterGateway}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)