You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2014/11/05 02:06:30 UTC
Review Request 27601: Adding resource consumption calculation for
cron jobs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27601/
-----------------------------------------------------------
Review request for Aurora.
Repository: aurora
Description
-------
Fixing cron template filtering issue.
This is the revision of the original implementation submitted in https://reviews.apache.org/r/27317 and subsequently reverted. The actual fix will follow shortly as a second diff to ease up reviewing.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java d4e0f5335c9ebd8da97cb9634152b46c2bd9affe
src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 3fbab8b27403a416e86c97970eb6124c8a34c38c
src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 2fe257416e8fc11be3ebf0dabbf4f63628b3c670
Diff: https://reviews.apache.org/r/27601/diff/
Testing
-------
./gradlew -Pq build
Also, created multiple role cron jobs in vagrant to validate filtering.
Thanks,
Maxim Khutornenko
Re: Review Request 27601: Adding resource consumption calculation for
cron jobs.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27601/#review61362
-----------------------------------------------------------
@ReviewBot retry
- Maxim Khutornenko
On Nov. 5, 2014, 1:23 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27601/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2014, 1:23 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-825
> https://issues.apache.org/jira/browse/AURORA-825
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fixing cron template filtering issue.
>
> This is the revision of the original implementation submitted in https://reviews.apache.org/r/27317 and reverted shorly after.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java d4e0f5335c9ebd8da97cb9634152b46c2bd9affe
> src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 3fbab8b27403a416e86c97970eb6124c8a34c38c
> src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 2fe257416e8fc11be3ebf0dabbf4f63628b3c670
>
> Diff: https://reviews.apache.org/r/27601/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> Also, created multiple role cron jobs in vagrant to validate filtering.
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 27601: Adding resource consumption calculation for
cron jobs.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27601/#review61365
-----------------------------------------------------------
Ship it!
Master (254e175) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Nov. 5, 2014, 1:23 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27601/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2014, 1:23 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-825
> https://issues.apache.org/jira/browse/AURORA-825
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fixing cron template filtering issue.
>
> This is the revision of the original implementation submitted in https://reviews.apache.org/r/27317 and reverted shorly after.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java d4e0f5335c9ebd8da97cb9634152b46c2bd9affe
> src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 3fbab8b27403a416e86c97970eb6124c8a34c38c
> src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 2fe257416e8fc11be3ebf0dabbf4f63628b3c670
>
> Diff: https://reviews.apache.org/r/27601/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> Also, created multiple role cron jobs in vagrant to validate filtering.
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 27601: Adding resource consumption calculation for
cron jobs.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27601/#review60349
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Nov. 5, 2014, 1:23 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27601/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2014, 1:23 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-825
> https://issues.apache.org/jira/browse/AURORA-825
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fixing cron template filtering issue.
>
> This is the revision of the original implementation submitted in https://reviews.apache.org/r/27317 and reverted shorly after.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java d4e0f5335c9ebd8da97cb9634152b46c2bd9affe
> src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 3fbab8b27403a416e86c97970eb6124c8a34c38c
> src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 2fe257416e8fc11be3ebf0dabbf4f63628b3c670
>
> Diff: https://reviews.apache.org/r/27601/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> Also, created multiple role cron jobs in vagrant to validate filtering.
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 27601: Adding resource consumption calculation for
cron jobs.
Posted by Bill Farner <wf...@apache.org>.
> On Nov. 6, 2014, 5:56 p.m., Maxim Khutornenko wrote:
> > Ping. The actual diff is tiny: https://reviews.apache.org/r/27601/diff/1-2/
Sorry, we've been in various firefights the last few days, reviewing shortly.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27601/#review60195
-----------------------------------------------------------
On Nov. 5, 2014, 1:23 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27601/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2014, 1:23 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-825
> https://issues.apache.org/jira/browse/AURORA-825
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fixing cron template filtering issue.
>
> This is the revision of the original implementation submitted in https://reviews.apache.org/r/27317 and reverted shorly after.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java d4e0f5335c9ebd8da97cb9634152b46c2bd9affe
> src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 3fbab8b27403a416e86c97970eb6124c8a34c38c
> src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 2fe257416e8fc11be3ebf0dabbf4f63628b3c670
>
> Diff: https://reviews.apache.org/r/27601/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> Also, created multiple role cron jobs in vagrant to validate filtering.
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 27601: Adding resource consumption calculation for
cron jobs.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27601/#review60195
-----------------------------------------------------------
Ping. The actual diff is tiny: https://reviews.apache.org/r/27601/diff/1-2/
- Maxim Khutornenko
On Nov. 5, 2014, 1:23 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27601/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2014, 1:23 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-825
> https://issues.apache.org/jira/browse/AURORA-825
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fixing cron template filtering issue.
>
> This is the revision of the original implementation submitted in https://reviews.apache.org/r/27317 and reverted shorly after.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java d4e0f5335c9ebd8da97cb9634152b46c2bd9affe
> src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 3fbab8b27403a416e86c97970eb6124c8a34c38c
> src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 2fe257416e8fc11be3ebf0dabbf4f63628b3c670
>
> Diff: https://reviews.apache.org/r/27601/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> Also, created multiple role cron jobs in vagrant to validate filtering.
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 27601: Adding resource consumption calculation for
cron jobs.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27601/#review59905
-----------------------------------------------------------
Master (9847b7b) is red with this patch.
./build-support/jenkins/build.sh
src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
src.test.python.apache.aurora.executor.gc_executor ..... SUCCESS
src.test.python.apache.aurora.executor.status_manager ..... SUCCESS
src.test.python.apache.aurora.executor.thermos_executor ..... SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner ..... SUCCESS
src.test.python.apache.thermos.bin.test_thermos ..... SUCCESS
src.test.python.apache.thermos.common.test_pathspec ..... SUCCESS
src.test.python.apache.thermos.common.test_planner ..... SUCCESS
src.test.python.apache.thermos.common.test_task_planner ..... SUCCESS
src.test.python.apache.thermos.config.test_schema ..... SUCCESS
src.test.python.apache.thermos.core.test_angry ..... SUCCESS
src.test.python.apache.thermos.core.test_ephemerals ..... SUCCESS
src.test.python.apache.thermos.core.test_failing_runner ..... SUCCESS
src.test.python.apache.thermos.core.test_failure_limit ..... SUCCESS
src.test.python.apache.thermos.core.test_finalization ..... SUCCESS
src.test.python.apache.thermos.core.test_helper ..... SUCCESS
src.test.python.apache.thermos.core.test_process ..... SUCCESS
src.test.python.apache.thermos.core.test_runner_integration ..... SUCCESS
src.test.python.apache.thermos.core.test_staged_kill ..... SUCCESS
src.test.python.apache.thermos.monitoring.test_disk ..... FAILURE
- Aurora ReviewBot
On Nov. 5, 2014, 1:23 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27601/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2014, 1:23 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-825
> https://issues.apache.org/jira/browse/AURORA-825
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fixing cron template filtering issue.
>
> This is the revision of the original implementation submitted in https://reviews.apache.org/r/27317 and reverted shorly after.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java d4e0f5335c9ebd8da97cb9634152b46c2bd9affe
> src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 3fbab8b27403a416e86c97970eb6124c8a34c38c
> src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 2fe257416e8fc11be3ebf0dabbf4f63628b3c670
>
> Diff: https://reviews.apache.org/r/27601/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> Also, created multiple role cron jobs in vagrant to validate filtering.
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 27601: Adding resource consumption calculation for
cron jobs.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27601/#review61309
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On Nov. 4, 2014, 5:23 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27601/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2014, 5:23 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-825
> https://issues.apache.org/jira/browse/AURORA-825
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fixing cron template filtering issue.
>
> This is the revision of the original implementation submitted in https://reviews.apache.org/r/27317 and reverted shorly after.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java d4e0f5335c9ebd8da97cb9634152b46c2bd9affe
> src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 3fbab8b27403a416e86c97970eb6124c8a34c38c
> src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 2fe257416e8fc11be3ebf0dabbf4f63628b3c670
>
> Diff: https://reviews.apache.org/r/27601/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> Also, created multiple role cron jobs in vagrant to validate filtering.
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 27601: Adding resource consumption calculation for
cron jobs.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27601/
-----------------------------------------------------------
(Updated Nov. 5, 2014, 1:23 a.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Changes
-------
Added ticket number.
Bugs: AURORA-825
https://issues.apache.org/jira/browse/AURORA-825
Repository: aurora
Description
-------
Fixing cron template filtering issue.
This is the revision of the original implementation submitted in https://reviews.apache.org/r/27317 and reverted shorly after.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java d4e0f5335c9ebd8da97cb9634152b46c2bd9affe
src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 3fbab8b27403a416e86c97970eb6124c8a34c38c
src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 2fe257416e8fc11be3ebf0dabbf4f63628b3c670
Diff: https://reviews.apache.org/r/27601/diff/
Testing
-------
./gradlew -Pq build
Also, created multiple role cron jobs in vagrant to validate filtering.
Thanks,
Maxim Khutornenko
Re: Review Request 27601: Adding resource consumption calculation for
cron jobs.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27601/
-----------------------------------------------------------
(Updated Nov. 5, 2014, 1:08 a.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Changes
-------
Actual fix.
Repository: aurora
Description (updated)
-------
Fixing cron template filtering issue.
This is the revision of the original implementation submitted in https://reviews.apache.org/r/27317 and reverted shorly after.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java d4e0f5335c9ebd8da97cb9634152b46c2bd9affe
src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 3fbab8b27403a416e86c97970eb6124c8a34c38c
src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 2fe257416e8fc11be3ebf0dabbf4f63628b3c670
Diff: https://reviews.apache.org/r/27601/diff/
Testing
-------
./gradlew -Pq build
Also, created multiple role cron jobs in vagrant to validate filtering.
Thanks,
Maxim Khutornenko