You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2018/06/18 15:52:11 UTC
Review Request 67631: Added non-const accessor for JSON values.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67631/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
Added a non-const version of Value::as<T>(),
to enable modifying json objects without
having to resort to the underlying boost functions.
Diffs
-----
3rdparty/stout/include/stout/json.hpp 5e738cf6f72f32b852beb61a16787e48082dab14
Diff: https://reviews.apache.org/r/67631/diff/1/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 67631: [WIP] Added non-const accessor for JSON
values.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67631/#review219398
-----------------------------------------------------------
Bad review!
Reviews applied: []
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Benjamin Bannier
On June 18, 2018, 3:52 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67631/
> -----------------------------------------------------------
>
> (Updated June 18, 2018, 3:52 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a non-const version of Value::as<T>(),
> to enable modifying json objects without
> having to resort to the underlying boost functions.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/json.hpp 5e738cf6f72f32b852beb61a16787e48082dab14
>
>
> Diff: https://reviews.apache.org/r/67631/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 67631: Added non-const accessor for JSON values.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67631/#review204941
-----------------------------------------------------------
Bad review!
Reviews applied: []
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot
On June 18, 2018, 3:52 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67631/
> -----------------------------------------------------------
>
> (Updated June 18, 2018, 3:52 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a non-const version of Value::as<T>(),
> to enable modifying json objects without
> having to resort to the underlying boost functions.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/json.hpp 5e738cf6f72f32b852beb61a16787e48082dab14
>
>
> Diff: https://reviews.apache.org/r/67631/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 67631: Added non-const accessor for JSON values.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67631/#review204933
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['67631']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67631
Relevant logs:
- [stout-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67631/logs/stout-tests-cmake-stdout.log):
```
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2768: 'JSON::Value::as': illegal use of explicit template arguments (compiling source file D:\DCOS\mesos\mesos\3rdparty\stout\tests\os\socket_tests.cpp) [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2244: 'JSON::Value::as': unable to match function definition to an existing declaration (compiling source file D:\DCOS\mesos\mesos\3rdparty\stout\tests\os\socket_tests.cpp) [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2988: unrecognizable template declaration/definition (compiling source file D:\DCOS\mesos\mesos\3rdparty\stout\tests\os\socket_tests.cpp) [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2059: syntax error: '<end Parse>' (compiling source file D:\DCOS\mesos\mesos\3rdparty\stout\tests\os\socket_tests.cpp) [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2143: syntax error: missing ';' before '{' (compiling source file D:\DCOS\mesos\mesos\3rdparty\stout\tests\os\socket_tests.cpp) [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2447: '{': missing function header (old-style formal list?) (compiling source file D:\DCOS\mesos\mesos\3rdparty\stout\tests\os\socket_tests.cpp) [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(364): error C2988: unrecognizable template declaration/definition (compiling source file D:\DCOS\mesos\mesos\3rdparty\stout\tests\os\strerror_tests.cpp) [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(364): error C2143: syntax error: missing ';' before '&' (compiling source file D:\DCOS\mesos\mesos\3rdparty\stout\tests\os\strerror_tests.cpp) [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int (compiling source file D:\DCOS\mesos\mesos\3rdparty\stout\tests\os\strerror_tests.cpp) [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2768: 'JSON::Value::as': illegal use of explicit template arguments (compiling source file D:\DCOS\mesos\mesos\3rdparty\stout\tests\os\strerror_tests.cpp) [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2244: 'JSON::Value::as': unable to match function definition to an existing declaration (compiling source file D:\DCOS\mesos\mesos\3rdparty\stout\tests\os\strerror_tests.cpp) [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2988: unrecognizable template declaration/definition (compiling source file D:\DCOS\mesos\mesos\3rdparty\stout\tests\os\strerror_tests.cpp) [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2059: syntax error: '<end Parse>' (compiling source file D:\DCOS\mesos\mesos\3rdparty\stout\tests\os\strerror_tests.cpp) [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2143: syntax error: missing ';' before '{' (compiling source file D:\DCOS\mesos\mesos\3rdparty\stout\tests\os\strerror_tests.cpp) [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2447: '{': missing function header (old-style formal list?) (compiling source file D:\DCOS\mesos\mesos\3rdparty\stout\tests\os\strerror_tests.cpp) [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(364): error C2988: unrecognizable template declaration/definition (compiling source file D:\DCOS\mesos\mesos\3rdparty\stout\tests\os\sendfile_tests.cpp) [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(364): error C2143: syntax error: missing ';' before '&' (compiling source file D:\DCOS\mesos\mesos\3rdparty\stout\tests\os\sendfile_tests.cpp) [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int (compiling source file D:\DCOS\mesos\mesos\3rdparty\stout\tests\os\sendfile_tests.cpp) [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2768: 'JSON::Value::as': illegal use of explicit template arguments (compiling source file D:\DCOS\mesos\mesos\3rdparty\stout\tests\os\sendfile_tests.cpp) [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2244: 'JSON::Value::as': unable to match function definition to an existing declaration (compiling source file D:\DCOS\mesos\mesos\3rdparty\stout\tests\os\sendfile_tests.cpp) [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2988: unrecognizable template declaration/definition (compiling source file D:\DCOS\mesos\mesos\3rdparty\stout\tests\os\sendfile_tests.cpp) [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2059: syntax error: '<end Parse>' (compiling source file D:\DCOS\mesos\mesos\3rdparty\stout\tests\os\sendfile_tests.cpp) [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2143: syntax error: missing ';' before '{' (compiling source file D:\DCOS\mesos\mesos\3rdparty\stout\tests\os\sendfile_tests.cpp) [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2447: '{': missing function header (old-style formal list?) (compiling source file D:\DCOS\mesos\mesos\3rdparty\stout\tests\os\sendfile_tests.cpp) [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
141 Warning(s)
162 Error(s)
Time Elapsed 00:10:38.59
```
- [libprocess-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67631/logs/libprocess-tests-cmake-stdout.log):
```
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2768: 'JSON::Value::as': illegal use of explicit template arguments (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\ssl\utilities.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2244: 'JSON::Value::as': unable to match function definition to an existing declaration (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\ssl\utilities.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2988: unrecognizable template declaration/definition (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\ssl\utilities.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2059: syntax error: '<end Parse>' (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\ssl\utilities.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2143: syntax error: missing ';' before '{' (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\ssl\utilities.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2447: '{': missing function header (old-style formal list?) (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\ssl\utilities.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(364): error C2988: unrecognizable template declaration/definition (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\openssl.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(364): error C2143: syntax error: missing ';' before '&' (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\openssl.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\openssl.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2768: 'JSON::Value::as': illegal use of explicit template arguments (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\openssl.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2244: 'JSON::Value::as': unable to match function definition to an existing declaration (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\openssl.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2988: unrecognizable template declaration/definition (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\openssl.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2059: syntax error: '<end Parse>' (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\openssl.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2143: syntax error: missing ';' before '{' (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\openssl.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2447: '{': missing function header (old-style formal list?) (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\openssl.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(364): error C2988: unrecognizable template declaration/definition (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\libevent_ssl_socket.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(364): error C2143: syntax error: missing ';' before '&' (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\libevent_ssl_socket.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\libevent_ssl_socket.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2768: 'JSON::Value::as': illegal use of explicit template arguments (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\libevent_ssl_socket.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2244: 'JSON::Value::as': unable to match function definition to an existing declaration (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\libevent_ssl_socket.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2988: unrecognizable template declaration/definition (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\libevent_ssl_socket.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2059: syntax error: '<end Parse>' (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\libevent_ssl_socket.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2143: syntax error: missing ';' before '{' (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\libevent_ssl_socket.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2447: '{': missing function header (old-style formal list?) (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\libevent_ssl_socket.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
112 Warning(s)
246 Error(s)
Time Elapsed 00:04:09.82
```
- [mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67631/logs/mesos-tests-cmake-stdout.log):
```
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2768: 'JSON::Value::as': illegal use of explicit template arguments (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\ssl\utilities.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2244: 'JSON::Value::as': unable to match function definition to an existing declaration (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\ssl\utilities.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2988: unrecognizable template declaration/definition (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\ssl\utilities.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2059: syntax error: '<end Parse>' (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\ssl\utilities.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2143: syntax error: missing ';' before '{' (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\ssl\utilities.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2447: '{': missing function header (old-style formal list?) (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\ssl\utilities.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(364): error C2988: unrecognizable template declaration/definition (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\openssl.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(364): error C2143: syntax error: missing ';' before '&' (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\openssl.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\openssl.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2768: 'JSON::Value::as': illegal use of explicit template arguments (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\openssl.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2244: 'JSON::Value::as': unable to match function definition to an existing declaration (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\openssl.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2988: unrecognizable template declaration/definition (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\openssl.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2059: syntax error: '<end Parse>' (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\openssl.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2143: syntax error: missing ';' before '{' (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\openssl.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2447: '{': missing function header (old-style formal list?) (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\openssl.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(364): error C2988: unrecognizable template declaration/definition (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\libevent_ssl_socket.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(364): error C2143: syntax error: missing ';' before '&' (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\libevent_ssl_socket.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\libevent_ssl_socket.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2768: 'JSON::Value::as': illegal use of explicit template arguments (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\libevent_ssl_socket.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2244: 'JSON::Value::as': unable to match function definition to an existing declaration (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\libevent_ssl_socket.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2988: unrecognizable template declaration/definition (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\libevent_ssl_socket.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2059: syntax error: '<end Parse>' (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\libevent_ssl_socket.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2143: syntax error: missing ';' before '{' (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\libevent_ssl_socket.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\json.hpp(365): error C2447: '{': missing function header (old-style formal list?) (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\libevent_ssl_socket.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
172 Warning(s)
248 Error(s)
Time Elapsed 00:05:48.91
```
- Mesos Reviewbot Windows
On June 18, 2018, 8:52 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67631/
> -----------------------------------------------------------
>
> (Updated June 18, 2018, 8:52 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a non-const version of Value::as<T>(),
> to enable modifying json objects without
> having to resort to the underlying boost functions.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/json.hpp 5e738cf6f72f32b852beb61a16787e48082dab14
>
>
> Diff: https://reviews.apache.org/r/67631/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>