You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/12/07 19:48:00 UTC
[jira] [Commented] (NIFI-4633) ProcessSession.clone(FlowFile)
throws FlowFileHandlingException incorrectly
[ https://issues.apache.org/jira/browse/NIFI-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16282415#comment-16282415 ]
ASF GitHub Bot commented on NIFI-4633:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2327
NIFI-4633
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-4633
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2327.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2327
----
commit fb9c9257dd0fd36fcbc728d534e8cff2ebeedc08
Author: Mark Payne <ma...@hotmail.com>
Date: 2017-12-07T19:12:34Z
NIFI-4633: Ensure that when ProcessSession.clone(FlowFile) is called, we obtain the most recent version of the FlowFile before attempting to obtain FlowFile size.
commit 969c2646cbb835dddc4f3f1ab281d7350158eaae
Author: Mark Payne <ma...@hotmail.com>
Date: 2017-12-07T19:44:10Z
NIFI-4633: Ensure that everywhere that a FlowFile is passed into ProcessSession that we used the most up-to-date version of it
----
> ProcessSession.clone(FlowFile) throws FlowFileHandlingException incorrectly
> ---------------------------------------------------------------------------
>
> Key: NIFI-4633
> URL: https://issues.apache.org/jira/browse/NIFI-4633
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.4.0
> Reporter: Mark Payne
> Assignee: Mark Payne
> Fix For: 1.5.0
>
>
> A message was received on the dev@ mailing list with the following situation:
> {quote}
> Hello,
> In updating our Nifi setup to 1.4.0, one of our regression tests started to
> fail.
> On investigation I ran into an issue with FlowFile state that has confused
> me.
> The following processor takes an input flow file, writes "NEW_DATA" to it,
> the clones it.
> It then outputs the original flowFile and the clone to different output
> relationships.
> I had expected that the two outputs would be the same, but if I run this
> through (using GenerateFlowFile to generate input), I get different output.
> If I play in data "OLD", then:
> OutputA receives a flowFile with the written content "NEW_DATA".
> OutputB receives the original content "OLD" that was sent into the
> processor.
> If instead I play in data longer than 8 bytes (ie longer than "NEW_DATA"),
> then CloneTestProcess errors and yields.
> The error from the logs is below.
> Any advice would be appreciated.
> Thanks in advance,
> Matthew Watson
> Code:
> {code}
> public class CloneTestProcessor extends AbstractProcessor {
> public static final Relationship OUTPUT_A = new
> Relationship.Builder().name("OUTPUT_A").build();
> public static final Relationship OUTPUT_B = new
> Relationship.Builder().name("OUTPUT_B").build();
> @Override
> public Set<Relationship> getRelationships() {
> return ImmutableSet.of(OUTPUT_A, OUTPUT_B);
> }
> @Override
> public void onTrigger(ProcessContext context, ProcessSession
> session) throws ProcessException {
> String DATA = "NEW_DATA";
> FlowFile flowFile = session.get();
> if(flowFile == null) {
> return;
> }
> FlowFile output = session.write(flowFile, (in, out) -> {
> out.write(DATA.getBytes());
> });
> FlowFile other = session.clone(flowFile);
> session.transfer(flowFile, OUTPUT_A);
> session.transfer(other, OUTPUT_B);
> }
> }
> {code}
> Error:
> {code}
> 2017-11-22 16:56:19,326 WARN [Timer-Driven Process Thread-10]
> o.a.n.c.t.ContinuallyRunProcessorTask
> org.apache.nifi.processor.exception.FlowFileHandlingException: Specified
> offset of 0 and size 9 exceeds size of
> StandardFlowFileRecord[uuid=5d279723-64a3-4ad2-a8f6-3f974baf38ce,claim=StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=1511369750666-1, container=default,
> section=1], offset=51, length=8],offset=0,name=29102663649743,size=8]
> at
> org.apache.nifi.controller.repository.StandardProcessSession.clone(StandardProcessSession.java:1672)
> at
> org.apache.nifi.controller.repository.StandardProcessSession.clone(StandardProcessSession.java:1662)
> at
> com.baesystemsai.nifi.utility.CloneTestProcessor.onTrigger(CloneTestProcessor.java:59)
> at
> org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
> at
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1119)
> at
> org.apache.nifi.controller.tasks.ContinuallyRunProcessorTask.call(ContinuallyRunProcessorTask.java:147)
> at
> org.apache.nifi.controller.tasks.ContinuallyRunProcessorTask.call(ContinuallyRunProcessorTask.java:47)
> at
> org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:128)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)