You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/08 07:22:56 UTC

[GitHub] [spark] HyukjinKwon opened a new pull request #24023: [SPARK-27102][R][PYTHON][CORE] Remove the references to Python's Scala codes in R's Scala codes

HyukjinKwon opened a new pull request #24023: [SPARK-27102][R][PYTHON][CORE] Remove the references to Python's Scala codes in R's Scala codes
URL: https://github.com/apache/spark/pull/24023
 
 
   ## What changes were proposed in this pull request?
   
   Currently, R's Scala codes happened to refer Python's Scala codes for code deduplications. It's a bit odd. For instance, when we face an exception from R, it shows python related code path, which makes confusing to debug. It should rather have one code base and R's and Python's should share.
   
   This PR proposes:
   
   1. Make a `SocketAuthServer` and move `PythonServer` so that `PythonRDD` and `RRDD` can share it.
   2. Move `readRDDFromFile` and `readRDDFromInputStream` into `JavaRDD`.
   3. Reuse `RAuthHelper` and remove `RSocketAuthHelper` in `RRDD`.
   4. Rename `getEncryptionEnabled` to `isEncryptionEnabled` while I am here.
   
   So, now, the places below:
   
   - `sql/core/src/main/scala/org/apache/spark/sql/api/r`
   - `core/src/main/scala/org/apache/spark/api/r`
   - `mllib/src/main/scala/org/apache/spark/ml/r`
   
   don't refer Python's Scala codes.
   
   ## How was this patch tested?
   
   Existing tests should cover this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org