You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "ss77892 (via GitHub)" <gi...@apache.org> on 2026/07/31 14:47:21 UTC
[PR] HDDS-16047. Certificate renewal stops permanently after an unexpected failure [ozone]
ss77892 opened a new pull request, #10915:
URL: https://github.com/apache/ozone/pull/10915
## What changes were proposed in this pull request?
HDDS-16047. Certificate renewal stops permanently after an unexpected failure
CertificateRenewerService is submitted with scheduleAtFixedRate. If the task throws an unchecked exception, the executor cancels every further execution, and the exception is only stored in a Future that nobody inspects, so nothing is logged. The component then never renews its certificate again. Recovery needs a restart, and by then there is no evidence of what stopped the renewal.
The renewal body is now wrapped so an unchecked failure is logged and the schedule is kept. Failures raised by the renewal itself are already reported as CertificateException and handled; the paths that can still throw unchecked sit outside that catch block: the certificate id save callback supplied by the service, the certificate reload, the backup directory cleanup, and the notification receivers.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16047
## How was this patch tested?
Adds a unit test that drives the renewer task with a renewal that throws an unchecked exception, and asserts the task contains it. The test invokes the task directly rather than waiting on the scheduler, so it stays deterministic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16047. Certificate renewal stops permanently after an unexpected failure [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #10915:
URL: https://github.com/apache/ozone/pull/10915#issuecomment-5201410826
Thanks @ss77892 for the patch, @fapifta, @yandrey321 for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16047. Certificate renewal stops permanently after an unexpected failure [ozone]
Posted by "ss77892 (via GitHub)" <gi...@apache.org>.
ss77892 commented on PR #10915:
URL: https://github.com/apache/ozone/pull/10915#issuecomment-5194495435
@fapifta can you take a look please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16047. Certificate renewal stops permanently after an unexpected failure [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #10915:
URL: https://github.com/apache/ozone/pull/10915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org