You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/02/05 07:31:41 UTC
[GitHub] [iceberg] liuml07 opened a new pull request #4048: Core: BaseRollingWriter to use DataWriter::write instead of DataWriter::add
liuml07 opened a new pull request #4048:
URL: https://github.com/apache/iceberg/pull/4048
The DataWriter::add is deprecated in 0.13 and will be removed in 0.14.
BaseRollingWriter should stop using the deprecated add() method.
Moreover, if a subclass of BaseRollingWriter only overrides the write()
method, add() should honor that.
In this patch I did not remove all calls to `DataWriter::add` in tests. May update that as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #4048: Core: BaseRollingWriter to use DataWriter::write instead of DataWriter::add
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #4048:
URL: https://github.com/apache/iceberg/pull/4048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #4048: Core: BaseRollingWriter to use DataWriter::write instead of DataWriter::add
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #4048:
URL: https://github.com/apache/iceberg/pull/4048#issuecomment-1030889807
I think it would be good to remove the usage in tests as well, but I'll go ahead and merge this since it's already been tested. Thank you, @liuml07!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] liuml07 commented on pull request #4048: Core: BaseRollingWriter to use DataWriter::write instead of DataWriter::add
Posted by GitBox <gi...@apache.org>.
liuml07 commented on pull request #4048:
URL: https://github.com/apache/iceberg/pull/4048#issuecomment-1031042255
Thank you very much @rdblue for prompt review and commit. I have filed #4053 as a follow-up for fixing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org