You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:26:17 UTC
[GitHub] [sling-org-apache-sling-javax-activation] bosschaert opened a new pull request #4: SLING-9612 Tune the nodeps javax.activation bundle to Java 8
bosschaert opened a new pull request #4:
URL: https://github.com/apache/sling-org-apache-sling-javax-activation/pull/4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-javax-activation] sonarcloud[bot] removed a comment on pull request #4: SLING-9612 Tune the nodeps javax.activation bundle to Java 8
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #4:
URL: https://github.com/apache/sling-org-apache-sling-javax-activation/pull/4#issuecomment-664943742
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=4&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=4&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=4&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=4&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=4&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=4&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=4&resolved
=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=4&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=4&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=4&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-javax-activation&pullRequest=4&metric=coverage&view=list) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-javax-activation&pullRequest=4&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-javax-activation&pullRequest=4&metric=new_duplicated_lines_density&view=list)
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/message_warning.png' alt='warning' width='16' height='16' /> The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more [here](https://sonarcloud.io/documentation/upcoming/)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-javax-activation] sonarcloud[bot] commented on pull request #4: SLING-9612 Tune the nodeps javax.activation bundle to Java 8
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #4:
URL: https://github.com/apache/sling-org-apache-sling-javax-activation/pull/4#issuecomment-664943742
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-javax-activation] bosschaert commented on a change in pull request #4: SLING-9612 Tune the nodeps javax.activation bundle to Java 8
Posted by GitBox <gi...@apache.org>.
bosschaert commented on a change in pull request #4:
URL: https://github.com/apache/sling-org-apache-sling-javax-activation/pull/4#discussion_r461494313
##########
File path: pom.xml
##########
@@ -58,8 +58,13 @@
</goals>
<configuration>
<bnd><![CDATA[
-Bundle-Name: ${project.name} (No embedded dependencies)
+Bundle-Name: ${project.name} (Framework Fragment, No embedded dependencies)
Bundle-SymbolicName: ${project.artifactId}.nodeps
+ExtensionBundle-Activator: org.apache.sling.javax.activation.internal.Activator
+Export-Package: javax.activation;version="0.0.0",com.sun.activation.registries;version="0.0.0",com.sun.activation.viewers;version="0.0.0"
Review comment:
Hi @kwin, my updated pr will not embed any more thanks to your link to https://groups.google.com/forum/#!topic/bndtools-users/NAdU0_X8OKY for the bnd instructions.
I agree that updating what is exported by the system bundle is a good idea. However I would still like to have the exports as defined by this PR in the bundle/fragment as I'd like to be able to run it with already released versions of Sling.
##########
File path: pom.xml
##########
@@ -72,7 +77,9 @@ Bundle-SymbolicName: ${project.artifactId}.nodeps
<bnd><![CDATA[
-includeresource:@jakarta.activation-[0-9.]*(-SNAPSHOT)?.jar
# version automatically determined from the MANIFEST.MF of the jakarta.activation.jar
+Bundle-Activator: org.apache.sling.javax.activation.internal.Activator
Review comment:
The nodeps bundle is a framework extension fragment. That one needs a different header: `ExtensionBundle-Activator` instead of `Bundle-Activator`, so I couldn't use the annotation for the 2 ways in which the activator was used.
The actual interface to be implemented by the Extension Bundle Activator is the same as the normal Bundle Activator.
##########
File path: pom.xml
##########
@@ -72,7 +77,9 @@ Bundle-SymbolicName: ${project.artifactId}.nodeps
<bnd><![CDATA[
-includeresource:@jakarta.activation-[0-9.]*(-SNAPSHOT)?.jar
# version automatically determined from the MANIFEST.MF of the jakarta.activation.jar
+Bundle-Activator: org.apache.sling.javax.activation.internal.Activator
Review comment:
The nodeps variant is a framework extension fragment. That one needs a different header: `ExtensionBundle-Activator` instead of `Bundle-Activator`, so I couldn't use the annotation for the 2 ways in which the activator was used.
The actual interface to be implemented by the Extension Bundle Activator is the same as the normal Bundle Activator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-javax-activation] bosschaert commented on pull request #4: SLING-9612 Tune the nodeps javax.activation bundle to Java 8
Posted by GitBox <gi...@apache.org>.
bosschaert commented on pull request #4:
URL: https://github.com/apache/sling-org-apache-sling-javax-activation/pull/4#issuecomment-665096073
Thanks for the review, @kwin !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-javax-activation] bosschaert merged pull request #4: SLING-9612 Tune the nodeps javax.activation bundle to Java 8
Posted by GitBox <gi...@apache.org>.
bosschaert merged pull request #4:
URL: https://github.com/apache/sling-org-apache-sling-javax-activation/pull/4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-javax-activation] kwin commented on a change in pull request #4: SLING-9612 Tune the nodeps javax.activation bundle to Java 8
Posted by GitBox <gi...@apache.org>.
kwin commented on a change in pull request #4:
URL: https://github.com/apache/sling-org-apache-sling-javax-activation/pull/4#discussion_r461480462
##########
File path: pom.xml
##########
@@ -58,8 +58,13 @@
</goals>
<configuration>
<bnd><![CDATA[
-Bundle-Name: ${project.name} (No embedded dependencies)
+Bundle-Name: ${project.name} (Framework Fragment, No embedded dependencies)
Bundle-SymbolicName: ${project.artifactId}.nodeps
+ExtensionBundle-Activator: org.apache.sling.javax.activation.internal.Activator
+Export-Package: javax.activation;version="0.0.0",com.sun.activation.registries;version="0.0.0",com.sun.activation.viewers;version="0.0.0"
Review comment:
This will embed. I would rather clean what is exported by the system bundle (https://lists.apache.org/thread.html/r0aa3c02c38b5026e24684a00de3c6c8506e166334e77892ac2ee0ab3%40%3Cdev.sling.apache.org%3E)
##########
File path: pom.xml
##########
@@ -72,7 +77,9 @@ Bundle-SymbolicName: ${project.artifactId}.nodeps
<bnd><![CDATA[
-includeresource:@jakarta.activation-[0-9.]*(-SNAPSHOT)?.jar
# version automatically determined from the MANIFEST.MF of the jakarta.activation.jar
+Bundle-Activator: org.apache.sling.javax.activation.internal.Activator
Review comment:
Why was the annotation from https://github.com/apache/sling-org-apache-sling-javax-activation/pull/4/files#diff-647f7f295a3a772b13eaaa75470004f7L52 not working?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org