You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "Ovilia (via GitHub)" <gi...@apache.org> on 2023/02/21 14:25:14 UTC

[GitHub] [echarts] Ovilia commented on pull request #18259: feat(tooltip): support relative length units for font-size. close #18253

Ovilia commented on PR #18259:
URL: https://github.com/apache/echarts/pull/18259#issuecomment-1438581244

   @sirAbramstone Yes, it's not using zrender. But if we are going to support units other than `px`, then it should also support these units for other options besides tooltip. Otherwise, the developers may get confused why some options support `rem` while some not. So it should be implemented in zrender and you have to make sure whenever `px` is supported, other units are also supported. For example, all options about `fontSize`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org