You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/02/26 11:54:59 UTC
[GitHub] [rocketmq] ProNic-QY opened a new pull request #1792: Fix get wrong client ip when client running in linux with container t…
ProNic-QY opened a new pull request #1792: Fix get wrong client ip when client running in linux with container t…
URL: https://github.com/apache/rocketmq/pull/1792
…ech, like docker will create docker0 network interface, etc..
## What is the purpose of the change
Some linux container tech will create many network interface, like docker/k8s cni, when rocketmq client run within those machine will get wrong client ip to generate clientId.
## Brief changelog
Skip network inteface as clientIP candidate when it's status is not up
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] xiangwangcheng commented on issue #1792: Fix get wrong client ip when client running in linux with container t…
Posted by GitBox <gi...@apache.org>.
xiangwangcheng commented on issue #1792: Fix get wrong client ip when client running in linux with container t…
URL: https://github.com/apache/rocketmq/pull/1792#issuecomment-605430444
Could you please change the destination branch to develop?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] ProNic-QY commented on issue #1792: Fix get wrong client ip when client running in linux with container t…
Posted by GitBox <gi...@apache.org>.
ProNic-QY commented on issue #1792: Fix get wrong client ip when client running in linux with container t…
URL: https://github.com/apache/rocketmq/pull/1792#issuecomment-605432506
> Could you please change the destination branch to develop?
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] CoderLan0668 commented on issue #1792: Fix get wrong client ip when client running in linux with container t…
Posted by GitBox <gi...@apache.org>.
CoderLan0668 commented on issue #1792: Fix get wrong client ip when client running in linux with container t…
URL: https://github.com/apache/rocketmq/pull/1792#issuecomment-591734450
it works in the container for aliyun eci, related to: #1791
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] ShannonDing commented on issue #1792: Fix get wrong client ip when client running in linux with container t…
Posted by GitBox <gi...@apache.org>.
ShannonDing commented on issue #1792: Fix get wrong client ip when client running in linux with container t…
URL: https://github.com/apache/rocketmq/pull/1792#issuecomment-607143945
link #1877
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] coveralls commented on issue #1792: Fix get wrong client ip when client running in linux with container t…
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1792: Fix get wrong client ip when client running in linux with container t…
URL: https://github.com/apache/rocketmq/pull/1792#issuecomment-591393153
[](https://coveralls.io/builds/28971242)
Coverage decreased (-0.05%) to 50.884% when pulling **92244a59f4cabdd5da83908880b02fc9a39774af on ProNic-QY:master** into **73bb4b402a5da02faf9feded8f4d79dd1ba88348 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services