You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/04/23 17:36:34 UTC
[GitHub] [spark] srowen commented on a diff in pull request #36296: [SPARK-38979][SQL] Improve error log readability in OrcUtils.requestedColumnIds
srowen commented on code in PR #36296:
URL: https://github.com/apache/spark/pull/36296#discussion_r856943887
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala:
##########
@@ -224,7 +224,9 @@ object OrcUtils extends Logging {
// the physical schema doesn't match the data schema).
// In these cases we map the physical schema to the data schema by index.
assert(orcFieldNames.length <= dataSchema.length, "The given data schema " +
- s"${dataSchema.catalogString} has less fields than the actual ORC physical schema, " +
+ s"${dataSchema.catalogString} (length:${dataSchema.length}) " +
+ s"has less ${orcFieldNames.length - dataSchema.length} fields than " +
Review Comment:
Tiny nit: less -> fewer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org