You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Marty Greenia (JIRA)" <ji...@apache.org> on 2010/06/27 07:14:49 UTC
[jira] Created: (CASSANDRA-1234) Extraneous tabs and whitespace in
code base
Extraneous tabs and whitespace in code base
-------------------------------------------
Key: CASSANDRA-1234
URL: https://issues.apache.org/jira/browse/CASSANDRA-1234
Project: Cassandra
Issue Type: Improvement
Components: Core
Affects Versions: 0.6.1
Environment: NA
Reporter: Marty Greenia
Priority: Trivial
Fix For: 0.7
There are tabs and extraneous spaces spread throughout the code that are contrary to the style guide.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1234) Extraneous tabs and whitespace
in code base
Posted by "Jeremy Hanna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924567#action_12924567 ]
Jeremy Hanna commented on CASSANDRA-1234:
-----------------------------------------
Oh - I thought this *was* "The Great Reformat" ticket. That's why I commented it on it.
> Extraneous tabs and whitespace in code base
> -------------------------------------------
>
> Key: CASSANDRA-1234
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1234
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.6.1
> Environment: NA
> Reporter: Marty Greenia
> Priority: Trivial
> Fix For: 0.7.0
>
> Attachments: 0001-Remove-tabs-and-whitespace.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> There are tabs and extraneous spaces spread throughout the code that are contrary to the style guide.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1234) Extraneous tabs and whitespace in
code base
Posted by "Marty Greenia (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marty Greenia updated CASSANDRA-1234:
-------------------------------------
Attachment: 0001-Remove-tabs-and-whitespace.patch
Cleans up tabs and whitespace in all files that had tabs in them.
> Extraneous tabs and whitespace in code base
> -------------------------------------------
>
> Key: CASSANDRA-1234
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1234
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.6.1
> Environment: NA
> Reporter: Marty Greenia
> Priority: Trivial
> Fix For: 0.7
>
> Attachments: 0001-Remove-tabs-and-whitespace.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> There are tabs and extraneous spaces spread throughout the code that are contrary to the style guide.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1234) Extraneous tabs and whitespace in
code base
Posted by "Marty Greenia (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marty Greenia updated CASSANDRA-1234:
-------------------------------------
Attachment: whitespace.0.patch
This patch cleans up all files with tabs, including any erroneous whitespace within those files.
> Extraneous tabs and whitespace in code base
> -------------------------------------------
>
> Key: CASSANDRA-1234
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1234
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.6.1
> Environment: NA
> Reporter: Marty Greenia
> Priority: Trivial
> Fix For: 0.7
>
> Attachments: whitespace.0.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> There are tabs and extraneous spaces spread throughout the code that are contrary to the style guide.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1234) Extraneous tabs and whitespace
in code base
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924565#action_12924565 ]
Sylvain Lebresne commented on CASSANDRA-1234:
---------------------------------------------
What is the plan for "The Great Reformat" ?
I would at least include what's in the previous comments + removing variable with underscores (but more care is needed for that).
> Extraneous tabs and whitespace in code base
> -------------------------------------------
>
> Key: CASSANDRA-1234
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1234
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.6.1
> Environment: NA
> Reporter: Marty Greenia
> Priority: Trivial
> Fix For: 0.7.0
>
> Attachments: 0001-Remove-tabs-and-whitespace.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> There are tabs and extraneous spaces spread throughout the code that are contrary to the style guide.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1234) Extraneous tabs and whitespace in
code base
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-1234:
--------------------------------------
Affects Version/s: (was: 0.6.1)
Fix Version/s: (was: 0.7.0)
Current plan is to do the stuff we can easily automate (bracing, whitespace) in all active branches simultaneously once we have no monster tickets like CASSANDRA-1472 or CASSANDRA-1072 outstanding, if ever.
I don't think underscore removal falls in that category since you can't just s/(\w+)_/$1/ because of the "this" problem in constructors with underscoreless parameters.
> Extraneous tabs and whitespace in code base
> -------------------------------------------
>
> Key: CASSANDRA-1234
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1234
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Environment: NA
> Reporter: Marty Greenia
> Priority: Trivial
> Attachments: 0001-Remove-tabs-and-whitespace.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> There are tabs and extraneous spaces spread throughout the code that are contrary to the style guide.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1234) Extraneous tabs and whitespace
in code base
Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924564#action_12924564 ]
Gary Dusbabek commented on CASSANDRA-1234:
------------------------------------------
Can we just have whoever does The Great Reformat to take care of this as well?
> Extraneous tabs and whitespace in code base
> -------------------------------------------
>
> Key: CASSANDRA-1234
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1234
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.6.1
> Environment: NA
> Reporter: Marty Greenia
> Priority: Trivial
> Fix For: 0.7.0
>
> Attachments: 0001-Remove-tabs-and-whitespace.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> There are tabs and extraneous spaces spread throughout the code that are contrary to the style guide.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1234) Extraneous tabs and whitespace in
code base
Posted by "Marty Greenia (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marty Greenia updated CASSANDRA-1234:
-------------------------------------
Comment: was deleted
(was: This patch cleans up all files with tabs, including any erroneous whitespace within those files.)
> Extraneous tabs and whitespace in code base
> -------------------------------------------
>
> Key: CASSANDRA-1234
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1234
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.6.1
> Environment: NA
> Reporter: Marty Greenia
> Priority: Trivial
> Fix For: 0.7
>
> Attachments: 0001-Remove-tabs-and-whitespace.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> There are tabs and extraneous spaces spread throughout the code that are contrary to the style guide.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1234) Extraneous tabs and whitespace
in code base
Posted by "Jeremy Hanna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924102#action_12924102 ]
Jeremy Hanna commented on CASSANDRA-1234:
-----------------------------------------
as part of this ticket, can we rename FBUtilities?
> Extraneous tabs and whitespace in code base
> -------------------------------------------
>
> Key: CASSANDRA-1234
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1234
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.6.1
> Environment: NA
> Reporter: Marty Greenia
> Priority: Trivial
> Fix For: 0.7.0
>
> Attachments: 0001-Remove-tabs-and-whitespace.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> There are tabs and extraneous spaces spread throughout the code that are contrary to the style guide.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1234) Extraneous tabs and whitespace in
code base
Posted by "Marty Greenia (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marty Greenia updated CASSANDRA-1234:
-------------------------------------
Attachment: (was: whitespace.0.patch)
> Extraneous tabs and whitespace in code base
> -------------------------------------------
>
> Key: CASSANDRA-1234
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1234
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.6.1
> Environment: NA
> Reporter: Marty Greenia
> Priority: Trivial
> Fix For: 0.7
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> There are tabs and extraneous spaces spread throughout the code that are contrary to the style guide.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.