You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by al...@apache.org on 2020/11/07 03:11:55 UTC
[incubator-datasketches-cpp] branch req_sketch updated (24e2de2 ->
bc2672a)
This is an automated email from the ASF dual-hosted git repository.
alsay pushed a change to branch req_sketch
in repository https://gitbox.apache.org/repos/asf/incubator-datasketches-cpp.git.
from 24e2de2 stream serialization
new 23f82e0 MS VC++ compatibility
new bc2672a explicit cast to avoid a warning
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
req/include/req_compactor_impl.hpp | 2 +-
req/include/req_quantile_calculator_impl.hpp | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[incubator-datasketches-cpp] 01/02: MS VC++ compatibility
Posted by al...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
alsay pushed a commit to branch req_sketch
in repository https://gitbox.apache.org/repos/asf/incubator-datasketches-cpp.git
commit 23f82e0034653e49a2a9340bb821311fe7409bda
Author: AlexanderSaydakov <Al...@users.noreply.github.com>
AuthorDate: Fri Nov 6 19:11:08 2020 -0800
MS VC++ compatibility
---
req/include/req_compactor_impl.hpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/req/include/req_compactor_impl.hpp b/req/include/req_compactor_impl.hpp
index 211075b..d803832 100755
--- a/req/include/req_compactor_impl.hpp
+++ b/req/include/req_compactor_impl.hpp
@@ -210,7 +210,7 @@ req_compactor<T, H, C, A> req_compactor<T, H, C, A>::deserialize(std::istream& i
for (uint32_t i = 0; i < num_items; ++i) {
serde.deserialize(is, item_buffer.get(), 1);
items.push_back(std::move(*item_buffer));
- item_buffer->~T();
+ (*item_buffer).~T();
}
if (!is.good()) throw std::runtime_error("error reading from std::istream");
return req_compactor(lg_weight, coin, sorted, section_size_raw, num_sections, num_compactions, state, std::move(items));
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[incubator-datasketches-cpp] 02/02: explicit cast to avoid a warning
Posted by al...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
alsay pushed a commit to branch req_sketch
in repository https://gitbox.apache.org/repos/asf/incubator-datasketches-cpp.git
commit bc2672aec0e61873c26deaf1cc8aa300b7a5f63a
Author: AlexanderSaydakov <Al...@users.noreply.github.com>
AuthorDate: Fri Nov 6 19:11:43 2020 -0800
explicit cast to avoid a warning
---
req/include/req_quantile_calculator_impl.hpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/req/include/req_quantile_calculator_impl.hpp b/req/include/req_quantile_calculator_impl.hpp
index bc143bf..fe6fcc9 100755
--- a/req/include/req_quantile_calculator_impl.hpp
+++ b/req/include/req_quantile_calculator_impl.hpp
@@ -49,7 +49,7 @@ void req_quantile_calculator<T, A>::convert_to_cummulative() {
template<typename T, typename A>
const T& req_quantile_calculator<T, A>::get_quantile(double rank) const {
- uint64_t weight = rank * n_;
+ uint64_t weight = static_cast<uint64_t>(rank * n_);
auto it = std::lower_bound(entries_.begin(), entries_.end(), Entry(nullptr, weight), compare_pairs_by_second());
if (it == entries_.end()) return *(entries_[entries_.size() - 1].first);
return *(it->first);
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org