You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/09 04:04:41 UTC

[GitHub] [airflow] Junnplus commented on a change in pull request #13563: Fix invalid continue_token for cleanup list pods

Junnplus commented on a change in pull request #13563:
URL: https://github.com/apache/airflow/pull/13563#discussion_r554287153



##########
File path: kubernetes_tests/test_cleanup_pods.py
##########
@@ -0,0 +1,35 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+import unittest
+from unittest import mock
+
+from airflow.cli import cli_parser
+from airflow.cli.commands import kubernetes_command
+from airflow.kubernetes.kube_client import get_kube_client
+
+
+class TestCleanupPods(unittest.TestCase):
+    @classmethod
+    def setUpClass(cls):
+        cls.parser = cli_parser.get_parser()
+
+    @mock.patch("airflow.cli.commands.kubernetes_command.get_kube_client")
+    def test_cleanup_pods_working(self, mock_client):
+        mock_client.return_value = get_kube_client(in_cluster=False)
+        kubernetes_command.cleanup_pods(
+            self.parser.parse_args(['kubernetes', 'cleanup-pods', '--namespace', 'test-namespace'])
+        )

Review comment:
       I think this test different with unit tests, this case maybe test with Kubernetes




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org