svn commit: r1023600 - /lucene/dev/trunk/solr/src/test/org/apache/solr/handler/FieldAnalysisRequestHandlerTest.java

[yo...@apache.org]

Author: yonik
Date: Mon Oct 18 00:04:31 2010
New Revision: 1023600

URL: http://svn.apache.org/viewvc?rev=1023600&view=rev
Log:
tests: close requests

Modified:
    lucene/dev/trunk/solr/src/test/org/apache/solr/handler/FieldAnalysisRequestHandlerTest.java

Modified: lucene/dev/trunk/solr/src/test/org/apache/solr/handler/FieldAnalysisRequestHandlerTest.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/src/test/org/apache/solr/handler/FieldAnalysisRequestHandlerTest.java?rev=1023600&r1=1023599&r2=1023600&view=diff
==============================================================================
--- lucene/dev/trunk/solr/src/test/org/apache/solr/handler/FieldAnalysisRequestHandlerTest.java (original)
+++ lucene/dev/trunk/solr/src/test/org/apache/solr/handler/FieldAnalysisRequestHandlerTest.java Mon Oct 18 00:04:31 2010
@@ -25,6 +25,7 @@ import org.apache.solr.common.params.Mod
 import org.apache.solr.common.util.NamedList;
 import org.apache.solr.client.solrj.request.FieldAnalysisRequest;
 import org.apache.solr.request.LocalSolrQueryRequest;
+import org.apache.solr.request.SolrQueryRequest;
 import org.junit.Before;
 import org.junit.BeforeClass;
 import org.junit.Test;
@@ -66,7 +67,8 @@ public class FieldAnalysisRequestHandler
     params.add(AnalysisParams.FIELD_VALUE, "the quick red fox jumped over the lazy brown dogs");
     params.add(CommonParams.Q, "fox brown");
 
-    FieldAnalysisRequest request = handler.resolveAnalysisRequest(new LocalSolrQueryRequest(h.getCore(), params));
+    SolrQueryRequest req = new LocalSolrQueryRequest(h.getCore(), params);
+    FieldAnalysisRequest request = handler.resolveAnalysisRequest(req);
     List<String> fieldNames = request.getFieldNames();
     assertEquals("Expecting 2 field names", 2, fieldNames.size());
     assertEquals("text", fieldNames.get(0));
@@ -78,25 +80,35 @@ public class FieldAnalysisRequestHandler
     assertEquals("the quick red fox jumped over the lazy brown dogs", request.getFieldValue());
     assertEquals("fox brown", request.getQuery());
     assertFalse(request.isShowMatch());
+    req.close();
 
     // testing overide of query value using analysis.query param
     params.add(AnalysisParams.QUERY, "quick lazy");
-    request = handler.resolveAnalysisRequest(new LocalSolrQueryRequest(h.getCore(), params));
+    req=new LocalSolrQueryRequest(h.getCore(), params);
+    request = handler.resolveAnalysisRequest(req);
     assertEquals("quick lazy", request.getQuery());
+    req.close();
 
     // testing analysis.showmatch param
     params.add(AnalysisParams.SHOW_MATCH, "false");
-    request = handler.resolveAnalysisRequest(new LocalSolrQueryRequest(h.getCore(), params));
+    req=new LocalSolrQueryRequest(h.getCore(), params);
+    request = handler.resolveAnalysisRequest(req);
     assertFalse(request.isShowMatch());
+    req.close();
+
     params.set(AnalysisParams.SHOW_MATCH, "true");
-    request = handler.resolveAnalysisRequest(new LocalSolrQueryRequest(h.getCore(), params));
+    req=new LocalSolrQueryRequest(h.getCore(), params);
+    request = handler.resolveAnalysisRequest(req);
     assertTrue(request.isShowMatch());
+    req.close();
 
     // testing absence of query value
     params.remove(CommonParams.Q);
     params.remove(AnalysisParams.QUERY);
-    request = handler.resolveAnalysisRequest(new LocalSolrQueryRequest(h.getCore(), params));
+    req=new LocalSolrQueryRequest(h.getCore(), params);
+    request = handler.resolveAnalysisRequest(req);
     assertNull(request.getQuery());
+    req.close();
   }
 
   /**