You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2022/02/04 09:22:37 UTC
[GitHub] [avro] martin-g commented on a change in pull request #1512: AVRO-3361 simplify if statement
martin-g commented on a change in pull request #1512:
URL: https://github.com/apache/avro/pull/1512#discussion_r799293116
##########
File path: lang/csharp/src/apache/main/File/NullCodec.cs
##########
@@ -59,9 +59,7 @@ public override string GetName()
/// <inheritdoc/>
public override bool Equals(object other)
{
- if (this == other)
- return true;
- return this.GetType().Name == other.GetType().Name;
+ return this == other ? true : GetType().Name == other.GetType().Name;
Review comment:
```suggestion
return this == other || GetType().Name == other.GetType().Name;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org