You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Attila Magyar <am...@hortonworks.com> on 2017/02/06 16:25:21 UTC

Review Request 56331: Updating yarn-env and hadoop-env templates with ZK secure options on stack upgrade

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56331/
-----------------------------------------------------------

Review request for Ambari, Attila Doroszlai, Robert Levas, and Sebastian Toader.


Bugs: AMBARI-19879
    https://issues.apache.org/jira/browse/AMBARI-19879


Repository: ambari


Description
-------

Secure ZK ACLs are supported >= HDP 2.6. If the user upgrades from an older version of HDP then Ambari should update yarn-env and hadoop-env templates with the secure ACL related options.


Diffs
-----

  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py c2ff457 
  ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/zkfc_slave.py 6a0d71f 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml f96b246 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 2bb2a72 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 290d3c5 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 4c17177 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml ea3de50 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 5371d3e 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 188e6f4 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml b975eba 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 291397a 

Diff: https://reviews.apache.org/r/56331/diff/


Testing
-------

Tested manually:
1.
  - created 2.4 cluster with YARN and HDFS
  - enabled namenode HA in HDFS
  - performed an express upgrade to 2.5
  - enabled kerberos
  - disabled kerberos

2.
  - created 2.4 cluster with YARN and HDFS
  - enabled namenode HA in HDFS
  - enabled kerberos
  - performed an express upgrade to 2.5  
  - disabled kerberos
  
  
Running unit tests...


Thanks,

Attila Magyar


Re: Review Request 56331: Updating yarn-env and hadoop-env templates with ZK secure options on stack upgrade

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56331/#review164368
-----------------------------------------------------------


Fix it, then Ship it!





ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml (line 291)
<https://reviews.apache.org/r/56331/#comment236053>

    HDFS and ZKFC in all caps.


- Alejandro Fernandez


On Feb. 6, 2017, 4:26 p.m., Attila Magyar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56331/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2017, 4:26 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19879
>     https://issues.apache.org/jira/browse/AMBARI-19879
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Secure ZK ACLs are supported >= HDP 2.6. If the user upgrades from an older version of HDP then Ambari should update yarn-env and hadoop-env templates with the secure ACL related options.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py c2ff457 
>   ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/zkfc_slave.py 6a0d71f 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml f96b246 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 2bb2a72 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 290d3c5 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 4c17177 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml ea3de50 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 5371d3e 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 188e6f4 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml b975eba 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 291397a 
> 
> Diff: https://reviews.apache.org/r/56331/diff/
> 
> 
> Testing
> -------
> 
> Tested manually:
> 1.
>   - created 2.5 cluster with YARN and HDFS
>   - enabled namenode HA in HDFS
>   - performed an express upgrade to 2.6
>   - enabled kerberos
>   - disabled kerberos
> 
> 2.
>   - created 2.5 cluster with YARN and HDFS
>   - enabled namenode HA in HDFS
>   - enabled kerberos
>   - performed an express upgrade to 2.6
>   - disabled kerberos
>   
>   
> Running unit tests...
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>


Re: Review Request 56331: Updating yarn-env and hadoop-env templates with ZK secure options on stack upgrade

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56331/#review164390
-----------------------------------------------------------


Fix it, then Ship it!





ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml (lines 289 - 291)
<https://reviews.apache.org/r/56331/#comment236082>

    As these are public-facing, let's make them a little less brief. Perhaps:
    
    Adding HDFS ZKFC Security ACLs
    
    Any place below which has "opts" as well - no need to abbreviate here.


- Jonathan Hurley


On Feb. 6, 2017, 11:26 a.m., Attila Magyar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56331/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2017, 11:26 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19879
>     https://issues.apache.org/jira/browse/AMBARI-19879
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Secure ZK ACLs are supported >= HDP 2.6. If the user upgrades from an older version of HDP then Ambari should update yarn-env and hadoop-env templates with the secure ACL related options.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py c2ff457 
>   ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/zkfc_slave.py 6a0d71f 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml f96b246 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 2bb2a72 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 290d3c5 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 4c17177 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml ea3de50 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 5371d3e 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 188e6f4 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml b975eba 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 291397a 
> 
> Diff: https://reviews.apache.org/r/56331/diff/
> 
> 
> Testing
> -------
> 
> Tested manually:
> 1.
>   - created 2.5 cluster with YARN and HDFS
>   - enabled namenode HA in HDFS
>   - performed an express upgrade to 2.6
>   - enabled kerberos
>   - disabled kerberos
> 
> 2.
>   - created 2.5 cluster with YARN and HDFS
>   - enabled namenode HA in HDFS
>   - enabled kerberos
>   - performed an express upgrade to 2.6
>   - disabled kerberos
>   
>   
> Running unit tests...
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>


Re: Review Request 56331: Updating yarn-env and hadoop-env templates with ZK secure options on stack upgrade

Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56331/#review164357
-----------------------------------------------------------


Ship it!




Ship It!

- Sebastian Toader


On Feb. 6, 2017, 5:26 p.m., Attila Magyar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56331/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2017, 5:26 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19879
>     https://issues.apache.org/jira/browse/AMBARI-19879
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Secure ZK ACLs are supported >= HDP 2.6. If the user upgrades from an older version of HDP then Ambari should update yarn-env and hadoop-env templates with the secure ACL related options.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py c2ff457 
>   ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/zkfc_slave.py 6a0d71f 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml f96b246 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 2bb2a72 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 290d3c5 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 4c17177 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml ea3de50 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 5371d3e 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 188e6f4 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml b975eba 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 291397a 
> 
> Diff: https://reviews.apache.org/r/56331/diff/
> 
> 
> Testing
> -------
> 
> Tested manually:
> 1.
>   - created 2.5 cluster with YARN and HDFS
>   - enabled namenode HA in HDFS
>   - performed an express upgrade to 2.6
>   - enabled kerberos
>   - disabled kerberos
> 
> 2.
>   - created 2.5 cluster with YARN and HDFS
>   - enabled namenode HA in HDFS
>   - enabled kerberos
>   - performed an express upgrade to 2.6
>   - disabled kerberos
>   
>   
> Running unit tests...
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>


Re: Review Request 56331: Updating yarn-env and hadoop-env templates with ZK secure options on stack upgrade

Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56331/#review164480
-----------------------------------------------------------


Fix it, then Ship it!





ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml (line 291)
<https://reviews.apache.org/r/56331/#comment236237>

    HDFS ZKFC all capital.



ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml (line 413)
<https://reviews.apache.org/r/56331/#comment236238>

    HDFS ZKFC all capital.



ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml (line 329)
<https://reviews.apache.org/r/56331/#comment236240>

    HDFS ZKFC all capital.


- Sebastian Toader


On Feb. 7, 2017, 10:02 a.m., Attila Magyar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56331/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2017, 10:02 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jonathan Hurley, Nate Cole, Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19879
>     https://issues.apache.org/jira/browse/AMBARI-19879
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Secure ZK ACLs are supported >= HDP 2.6. If the user upgrades from an older version of HDP then Ambari should update yarn-env and hadoop-env templates with the secure ACL related options.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py c2ff457 
>   ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/zkfc_slave.py 6a0d71f 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml f96b246 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 2bb2a72 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 290d3c5 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 4c17177 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml ea3de50 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 5371d3e 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 188e6f4 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml b975eba 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 291397a 
> 
> Diff: https://reviews.apache.org/r/56331/diff/
> 
> 
> Testing
> -------
> 
> Tested manually:
> 1.
>   - created 2.5 cluster with YARN and HDFS
>   - enabled namenode HA in HDFS
>   - performed an express upgrade to 2.6
>   - enabled kerberos
>   - disabled kerberos
> 
> 2.
>   - created 2.5 cluster with YARN and HDFS
>   - enabled namenode HA in HDFS
>   - enabled kerberos
>   - performed an express upgrade to 2.6
>   - disabled kerberos
>   
> 
> Unit tests:
> Results :
> Tests run: 4906, Failures: 0, Errors: 0, Skipped: 39
> Ran 270 tests in 6.899s
> OK
> Ran 455 tests in 101.750s
> ----------------------------------------------------------------------
> Total run:1182
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>


Re: Review Request 56331: Updating yarn-env and hadoop-env templates with ZK secure options on stack upgrade

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56331/#review164511
-----------------------------------------------------------


Ship it!




Ship It!

- Nate Cole


On Feb. 7, 2017, 4:59 a.m., Attila Magyar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56331/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2017, 4:59 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jonathan Hurley, Nate Cole, Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19879
>     https://issues.apache.org/jira/browse/AMBARI-19879
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Secure ZK ACLs are supported >= HDP 2.6. If the user upgrades from an older version of HDP then Ambari should update yarn-env and hadoop-env templates with the secure ACL related options.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py c2ff457 
>   ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/zkfc_slave.py 6a0d71f 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml f96b246 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 2bb2a72 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 290d3c5 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 4c17177 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml ea3de50 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 5371d3e 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 188e6f4 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml b975eba 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 291397a 
> 
> Diff: https://reviews.apache.org/r/56331/diff/
> 
> 
> Testing
> -------
> 
> Tested manually:
> 1.
>   - created 2.5 cluster with YARN and HDFS
>   - enabled namenode HA in HDFS
>   - performed an express upgrade to 2.6
>   - enabled kerberos
>   - disabled kerberos
> 
> 2.
>   - created 2.5 cluster with YARN and HDFS
>   - enabled namenode HA in HDFS
>   - enabled kerberos
>   - performed an express upgrade to 2.6
>   - disabled kerberos
>   
> 
> Unit tests:
> Results :
> Tests run: 4906, Failures: 0, Errors: 0, Skipped: 39
> Ran 270 tests in 6.899s
> OK
> Ran 455 tests in 101.750s
> ----------------------------------------------------------------------
> Total run:1182
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>


Re: Review Request 56331: Updating yarn-env and hadoop-env templates with ZK secure options on stack upgrade

Posted by Attila Magyar <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56331/
-----------------------------------------------------------

(Updated Feb. 7, 2017, 9:59 a.m.)


Review request for Ambari, Attila Doroszlai, Jonathan Hurley, Nate Cole, Robert Levas, and Sebastian Toader.


Changes
-------

missed some texts


Bugs: AMBARI-19879
    https://issues.apache.org/jira/browse/AMBARI-19879


Repository: ambari


Description
-------

Secure ZK ACLs are supported >= HDP 2.6. If the user upgrades from an older version of HDP then Ambari should update yarn-env and hadoop-env templates with the secure ACL related options.


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py c2ff457 
  ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/zkfc_slave.py 6a0d71f 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml f96b246 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 2bb2a72 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 290d3c5 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 4c17177 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml ea3de50 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 5371d3e 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 188e6f4 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml b975eba 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 291397a 

Diff: https://reviews.apache.org/r/56331/diff/


Testing
-------

Tested manually:
1.
  - created 2.5 cluster with YARN and HDFS
  - enabled namenode HA in HDFS
  - performed an express upgrade to 2.6
  - enabled kerberos
  - disabled kerberos

2.
  - created 2.5 cluster with YARN and HDFS
  - enabled namenode HA in HDFS
  - enabled kerberos
  - performed an express upgrade to 2.6
  - disabled kerberos
  

Unit tests:
Results :
Tests run: 4906, Failures: 0, Errors: 0, Skipped: 39
Ran 270 tests in 6.899s
OK
Ran 455 tests in 101.750s
----------------------------------------------------------------------
Total run:1182
Total errors:0
Total failures:0


Thanks,

Attila Magyar


Re: Review Request 56331: Updating yarn-env and hadoop-env templates with ZK secure options on stack upgrade

Posted by Attila Magyar <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56331/
-----------------------------------------------------------

(Updated Feb. 7, 2017, 9:02 a.m.)


Review request for Ambari, Attila Doroszlai, Jonathan Hurley, Nate Cole, Robert Levas, and Sebastian Toader.


Changes
-------

finished running unittests


Bugs: AMBARI-19879
    https://issues.apache.org/jira/browse/AMBARI-19879


Repository: ambari


Description
-------

Secure ZK ACLs are supported >= HDP 2.6. If the user upgrades from an older version of HDP then Ambari should update yarn-env and hadoop-env templates with the secure ACL related options.


Diffs
-----

  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py c2ff457 
  ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/zkfc_slave.py 6a0d71f 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml f96b246 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 2bb2a72 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 290d3c5 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 4c17177 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml ea3de50 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 5371d3e 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 188e6f4 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml b975eba 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 291397a 

Diff: https://reviews.apache.org/r/56331/diff/


Testing (updated)
-------

Tested manually:
1.
  - created 2.5 cluster with YARN and HDFS
  - enabled namenode HA in HDFS
  - performed an express upgrade to 2.6
  - enabled kerberos
  - disabled kerberos

2.
  - created 2.5 cluster with YARN and HDFS
  - enabled namenode HA in HDFS
  - enabled kerberos
  - performed an express upgrade to 2.6
  - disabled kerberos
  

Unit tests:
Results :
Tests run: 4906, Failures: 0, Errors: 0, Skipped: 39
Ran 270 tests in 6.899s
OK
Ran 455 tests in 101.750s
----------------------------------------------------------------------
Total run:1182
Total errors:0
Total failures:0


Thanks,

Attila Magyar


Re: Review Request 56331: Updating yarn-env and hadoop-env templates with ZK secure options on stack upgrade

Posted by Attila Magyar <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56331/
-----------------------------------------------------------

(Updated Feb. 7, 2017, 8:56 a.m.)


Review request for Ambari, Attila Doroszlai, Jonathan Hurley, Nate Cole, Robert Levas, and Sebastian Toader.


Changes
-------

+1 text update


Bugs: AMBARI-19879
    https://issues.apache.org/jira/browse/AMBARI-19879


Repository: ambari


Description
-------

Secure ZK ACLs are supported >= HDP 2.6. If the user upgrades from an older version of HDP then Ambari should update yarn-env and hadoop-env templates with the secure ACL related options.


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py c2ff457 
  ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/zkfc_slave.py 6a0d71f 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml f96b246 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 2bb2a72 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 290d3c5 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 4c17177 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml ea3de50 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 5371d3e 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 188e6f4 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml b975eba 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 291397a 

Diff: https://reviews.apache.org/r/56331/diff/


Testing
-------

Tested manually:
1.
  - created 2.5 cluster with YARN and HDFS
  - enabled namenode HA in HDFS
  - performed an express upgrade to 2.6
  - enabled kerberos
  - disabled kerberos

2.
  - created 2.5 cluster with YARN and HDFS
  - enabled namenode HA in HDFS
  - enabled kerberos
  - performed an express upgrade to 2.6
  - disabled kerberos
  
  
Running unit tests...


Thanks,

Attila Magyar


Re: Review Request 56331: Updating yarn-env and hadoop-env templates with ZK secure options on stack upgrade

Posted by Attila Magyar <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56331/
-----------------------------------------------------------

(Updated Feb. 7, 2017, 8:45 a.m.)


Review request for Ambari, Attila Doroszlai, Jonathan Hurley, Nate Cole, Robert Levas, and Sebastian Toader.


Changes
-------

updated texts


Bugs: AMBARI-19879
    https://issues.apache.org/jira/browse/AMBARI-19879


Repository: ambari


Description
-------

Secure ZK ACLs are supported >= HDP 2.6. If the user upgrades from an older version of HDP then Ambari should update yarn-env and hadoop-env templates with the secure ACL related options.


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py c2ff457 
  ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/zkfc_slave.py 6a0d71f 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml f96b246 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 2bb2a72 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 290d3c5 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 4c17177 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml ea3de50 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 5371d3e 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 188e6f4 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml b975eba 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 291397a 

Diff: https://reviews.apache.org/r/56331/diff/


Testing
-------

Tested manually:
1.
  - created 2.5 cluster with YARN and HDFS
  - enabled namenode HA in HDFS
  - performed an express upgrade to 2.6
  - enabled kerberos
  - disabled kerberos

2.
  - created 2.5 cluster with YARN and HDFS
  - enabled namenode HA in HDFS
  - enabled kerberos
  - performed an express upgrade to 2.6
  - disabled kerberos
  
  
Running unit tests...


Thanks,

Attila Magyar


Re: Review Request 56331: Updating yarn-env and hadoop-env templates with ZK secure options on stack upgrade

Posted by Attila Magyar <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56331/
-----------------------------------------------------------

(Updated Feb. 6, 2017, 4:26 p.m.)


Review request for Ambari, Attila Doroszlai, Robert Levas, and Sebastian Toader.


Changes
-------

fixed version in testing description


Bugs: AMBARI-19879
    https://issues.apache.org/jira/browse/AMBARI-19879


Repository: ambari


Description
-------

Secure ZK ACLs are supported >= HDP 2.6. If the user upgrades from an older version of HDP then Ambari should update yarn-env and hadoop-env templates with the secure ACL related options.


Diffs
-----

  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py c2ff457 
  ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/zkfc_slave.py 6a0d71f 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml f96b246 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 2bb2a72 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 290d3c5 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 4c17177 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml ea3de50 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 5371d3e 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 188e6f4 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml b975eba 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 291397a 

Diff: https://reviews.apache.org/r/56331/diff/


Testing (updated)
-------

Tested manually:
1.
  - created 2.5 cluster with YARN and HDFS
  - enabled namenode HA in HDFS
  - performed an express upgrade to 2.6
  - enabled kerberos
  - disabled kerberos

2.
  - created 2.5 cluster with YARN and HDFS
  - enabled namenode HA in HDFS
  - enabled kerberos
  - performed an express upgrade to 2.6
  - disabled kerberos
  
  
Running unit tests...


Thanks,

Attila Magyar