You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Alastair Maw (JIRA)" <ji...@apache.org> on 2007/06/19 17:50:26 UTC

[jira] Updated: (WICKET-501) JavaScript comment stripping doesn't handle regexps

     [ https://issues.apache.org/jira/browse/WICKET-501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alastair Maw updated WICKET-501:
--------------------------------

    Summary: JavaScript comment stripping doesn't handle regexps  (was: JavaScript comment stripping doesn't handle // inside String literals. )

Actually, it doesn't handle the regexps above that properly, and therefore thinks it's in the middle of a string.

> JavaScript comment stripping doesn't handle regexps
> ---------------------------------------------------
>
>                 Key: WICKET-501
>                 URL: https://issues.apache.org/jira/browse/WICKET-501
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-beta1
>            Reporter: Peter Ertl
>            Assignee: Alastair Maw
>            Priority: Critical
>             Fix For: 1.3.0-beta2
>
>         Attachments: 20070425-WICKET-501-JavascriptStripper.txt, jquery-06-19-07-stripped.js, jquery-06-19-07.js
>
>
> The following line is crippled when using javascript comment stripping
> (from jquery.js)
>     // Handle the common XPath // expression
>     if ( !t.indexOf("//") ) {
> it will be result in
>     if ( !t.indexOf("
> the // inside the string quotes are taken as a comment instead of as a string...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.