[GitHub] [superset] zhaoyongjie commented on pull request #18181: fix: Explore long URL problem

[GitBox <gi...@apache.org>]

zhaoyongjie commented on pull request #18181:
URL: https://github.com/apache/superset/pull/18181#issuecomment-1041516402


   I'm considering whether we should do a redesign if possible. I think it
   would be not hard to make the `key-value` system either store in the
   database, or store in the cache system.
   
   On Wed, Feb 16, 2022 at 9:41 PM Ville Brofeldt ***@***.***>
   wrote:
   
   > I agree with @michael-s-molina <https://github.com/michael-s-molina> - we
   > really should have surfaced this as a SIP, and this was clearly a fault in
   > the process, and I assume full responsibility for my part in this
   > oversight. My sincerest apologies for this. I will do my best to make sure
   > similar lapses in process don't happen in the future.
   >
   > I think the points brought up above were a good summary of why we felt
   > this change was needed and why this approach was taken, but obviously this
   > discussion should have taken place prior to PRs in the open. Like @nytai
   > <https://github.com/nytai> mentioned, the fallout caused by this will be
   > difficult to undo at this point, but any potential improvements that come
   > to mind are warmly welcomed and would be good to address before the 1.5 and
   > 2.0 cuts. One safeguard that comes to mind is adding an optional allowlist
   > to config.py for acceptable cache backends. By setting ALLOWED_CACHE_BACKENDS
   > = ["RedisCache"], it would be possible to ensure that cache
   > misconfigurations like these would be caught during testing.
   >
   > On a related note, it appears the long URL problem has gotten worse when
   > moving from 1.3 to 1.4: #18198
   > <https://github.com/apache/superset/issues/18198> (I have been unable to
   > identify what is causing this).
   >
   > —
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/superset/pull/18181#issuecomment-1041503788>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAPMKUVHMWGRFZQGEUTTPMTU3OSRRANCNFSM5M33YICQ>
   > .
   > Triage notifications on the go with GitHub Mobile for iOS
   > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
   > or Android
   > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
   >
   > You are receiving this because you were mentioned.Message ID:
   > ***@***.***>
   >
   
   
   -- 
   
   Best regards,
   
   Yongjie
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org