You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/05/18 10:44:58 UTC
[GitHub] [hive] zabetak opened a new pull request #2288: Replace parquet-hadoop-bundle dependency with the actual parquet modules
zabetak opened a new pull request #2288:
URL: https://github.com/apache/hive/pull/2288
### What changes were proposed in this pull request and why?
The parquet-hadoop-bundle is not a real dependency but a mere packaging
of three parquet modules to create an uber jar. The Parquet community
created this artificial module on demand by HIVE-5783 but the
benefits if any are unclear.
On the contrary using the uber dependency has some drawbacks:
-Parquet souce code cannot be attached easily in IDEs which makes
debugging sessions cumbersome.
-Finding concrete dependencies with Parquet is not possible
just by inspecting the pom files.
-Extra maintenance cost for the Parquet community adding
additional verification steps during a release.
For the reasons above the uber dependency is replaced with concrete
dependencies to the respective modules:
* parquet-common
* parquet-column
* parquet-hadoop
No need to exclude ord.codehaus.jackson from parquet in the shaded
hive-jdbc jar cause its not a compile dependency in the afforementioned
Parquet modules (at the current version).
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Existing tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk commented on pull request #2288: HIVE-25296: Replace parquet-hadoop-bundle dependency with the actual parquet modules
Posted by GitBox <gi...@apache.org>.
kgyrtkirk commented on pull request #2288:
URL: https://github.com/apache/hive/pull/2288#issuecomment-874568565
looking at the jar contents I see
* some slf4j stuff in the jar
* a parquet.thrift at the root which is a bit odd to me
* a thrift runtime
* some jackson stuff
I would be a bit worried from the above for the thrift runtime/compatibility - could you do a real world test to launch some tez containers and/or llap to see if everything is working properly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] closed pull request #2288: HIVE-25296: Replace parquet-hadoop-bundle dependency with the actual parquet modules
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #2288:
URL: https://github.com/apache/hive/pull/2288
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk commented on pull request #2288: HIVE-25296: Replace parquet-hadoop-bundle dependency with the actual parquet modules
Posted by GitBox <gi...@apache.org>.
kgyrtkirk commented on pull request #2288:
URL: https://github.com/apache/hive/pull/2288#issuecomment-874568565
looking at the jar contents I see
* some slf4j stuff in the jar
* a parquet.thrift at the root which is a bit odd to me
* a thrift runtime
* some jackson stuff
I would be a bit worried from the above for the thrift runtime/compatibility - could you do a real world test to launch some tez containers and/or llap to see if everything is working properly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #2288: HIVE-25296: Replace parquet-hadoop-bundle dependency with the actual parquet modules
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #2288:
URL: https://github.com/apache/hive/pull/2288#issuecomment-913058810
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org