[GitHub] [spark] HeartSaVioR commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui

[GitBox <gi...@apache.org>]

HeartSaVioR commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui
URL: https://github.com/apache/spark/pull/26201#issuecomment-544848464
 
 
   Amazing work! I've seen multiple requests on having tab for structured streaming be equivalent to streaming tab, and happy to see this effort.
   
   I've just skimmed through the code (don't know about front-end tech.) and have general comment:
   
   * It may be better to define a new event for SQL and pass through listener bus, so that it could be available to SHS as well. It seems to be the right approach even we just want to expose it in running application.
   * Is there any chance to reuse resources for streaming tab? It's basically close to streaming tab, but looks like it doesn't reuse anything.
   * At least we could add UTs for API layer.
   * It would be great if statistic page would have query information as well on top.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org