You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by sp...@apache.org on 2026/08/21 12:41:07 UTC
(tinkerpop) 02/04: Filter the commit window on committer date
This is an automated email from the ASF dual-hosted git repository.
spmallette pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
commit 5818ca9b7d45e17498101db024f6879e159791f6
Author: Stephen Mallette <st...@amazon.com>
AuthorDate: Fri Aug 21 08:33:12 2026 -0400
Filter the commit window on committer date
`git log --since` compares the author date, so a merged pull request carrying a
contributor's older authoring date dropped out of the window that exists to catch
it. Filters on committer date instead, with a day of slack for a root opened once
work was already under way.
Assisted-by: Claude Code:claude-opus-5
---
bin/beads-commits.py | 22 ++++++++++++++++++++--
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/bin/beads-commits.py b/bin/beads-commits.py
index 38350a1988..229a875d90 100755
--- a/bin/beads-commits.py
+++ b/bin/beads-commits.py
@@ -74,6 +74,7 @@ import json
import re
import subprocess
import sys
+from datetime import datetime
def git(*args):
@@ -175,8 +176,25 @@ def suggest(root, branch):
# The window is shown even when records identified something. A ticket id only
# finds the commits that quote it, and a follow-up fix or a docs pass usually
# does not, so returning here would hide exactly the commits most easily lost.
- since = (bead.get("started_at") or bead.get("created_at") or "")[:10]
- window = git("log", "--format=%H", f"--since={since}", "-25", ref).splitlines() if since else []
+ # Filter on committer date, in Python, because `git log --since` compares the
+ # AUTHOR date. A merged pull request carries the contributor's authoring date,
+ # often weeks before it landed, so --since would drop the commits this window
+ # exists to catch.
+ stamp = bead.get("started_at") or bead.get("created_at") or ""
+ since = stamp[:10]
+ window = []
+ if stamp:
+ # A day of slack. PRIME.md has the root created before the code, but a root
+ # is sometimes opened once work is already under way, and the operator
+ # confirms this list. Showing a commit that does not belong costs a glance;
+ # hiding one that does costs the link entirely.
+ cutoff = datetime.fromisoformat(stamp.replace("Z", "+00:00")).timestamp() - 86400
+ for entry in git("log", "--format=%H %ct", "-200", ref).splitlines():
+ sha, _, committed = entry.partition(" ")
+ if int(committed) >= cutoff:
+ window.append(sha)
+ if len(window) >= 25:
+ break
mine = (git("config", "user.email") or "").lower()
def line(sha):