You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/09/28 10:26:01 UTC
[GitHub] [netbeans] DevCharly opened a new pull request, #4696: Update FlatLaf from 2.4 to 2.5
DevCharly opened a new pull request, #4696:
URL: https://github.com/apache/netbeans/pull/4696
Update FlatLaf to v2.5.
Changes: https://github.com/JFormDesigner/FlatLaf/releases/tag/2.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4696: Update FlatLaf from 2.4 to 2.5
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #4696:
URL: https://github.com/apache/netbeans/pull/4696#issuecomment-1264465350
> @matthiasblaesing that change looks a good idea.
Thanks for having a look.
> I wonder if we should be pre-extracting the native libs similarly to [how JNA module does it](https://github.com/apache/netbeans/blob/master/platform/libs.jna/nbproject/project.properties) here?
In theory a good idea, in practice extracting libraries needs a way to force loading through `System#loadLibrary` with the basename only. In FlatLaf the loading always goes through extraction and loading target with full path. We'd need to modify this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] DevCharly commented on pull request #4696: Update FlatLaf from 2.4 to 2.5
Posted by GitBox <gi...@apache.org>.
DevCharly commented on PR #4696:
URL: https://github.com/apache/netbeans/pull/4696#issuecomment-1263986747
@matthiasblaesing Done. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] DevCharly commented on pull request #4696: Update FlatLaf from 2.4 to 2.5
Posted by GitBox <gi...@apache.org>.
DevCharly commented on PR #4696:
URL: https://github.com/apache/netbeans/pull/4696#issuecomment-1263989616
@mbastian could you try whether the added implementation version works with your FlatLaf-SwingX module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4696: Update FlatLaf from 2.4 to 2.5
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #4696:
URL: https://github.com/apache/netbeans/pull/4696#issuecomment-1263957941
Change looks sane to me, however I suggest to include this in this change set (if in doubt, feel free to squash it into your commit):
https://github.com/apache/netbeans/commit/66716b5506d91257f8ea136ffb11a669bac53f3a
The intention is to fix the issue described in #4619. @neilcsmith-net it would be nice if you could have a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4696: Update FlatLaf from 2.4 to 2.5
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4696:
URL: https://github.com/apache/netbeans/pull/4696#issuecomment-1274320657
@DevCharly sorry, looks like our PRs conflicted in changes to `Installer`. Are you able to update and resolve?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4696: Update FlatLaf from 2.4 to 2.5
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #4696:
URL: https://github.com/apache/netbeans/pull/4696#issuecomment-1264675089
@neilcsmith-net thank you for the pointer - I looked one level to deep. What do you think about this:
https://github.com/apache/netbeans/commit/6781772b899fdfeaf855ed6b20d071b8bcf5fe60
@DevCharly the referenced commit should change the library loading, so that the library is loaded from the pre-extracted version in the modules directory. The issue with self extracting libraries is two fold: The first problem is cleanup - windows only lets you remove libraries after the users are closed, the second problem is on linux the temp directory could be mounted `noexec`, which also prevends library loading. As NetBeans needs to be executed, it can be expected, that the modules are located in an executable location.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4696: Update FlatLaf from 2.4 to 2.5
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4696:
URL: https://github.com/apache/netbeans/pull/4696#issuecomment-1264336570
@matthiasblaesing that change looks a good idea.
I wonder if we should be pre-extracting the native libs similarly to [how JNA module does it](https://github.com/apache/netbeans/blob/master/platform/libs.jna/nbproject/project.properties) here?
Aside @DevCharly - while looking at FlatLaf code for native loading noticed the comments on libjawt. Similar to #4441 and https://github.com/java-native-access/jna/pull/1422 Probably good to always preload.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4696: Update FlatLaf from 2.4 to 2.5
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #4696:
URL: https://github.com/apache/netbeans/pull/4696#issuecomment-1264714671
@neilcsmith-net valid point updated to:
https://github.com/apache/netbeans/commit/be4dba61b9f6aa74089798095663fa3b917923d8
@DevCharly if you consider this, please use this commit, not the previous one, I replaced it based on Neils comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4696: Update FlatLaf from 2.4 to 2.5
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4696:
URL: https://github.com/apache/netbeans/pull/4696#issuecomment-1264613945
> In FlatLaf the loading always goes through extraction and loading target with full path.
Yes, I saw. We'd need to set [this](https://github.com/JFormDesigner/FlatLaf/blob/main/flatlaf-core/src/main/java/com/formdev/flatlaf/FlatSystemProperties.java#L164) in the module installer.
Let's merge as is, but keep this in mind if we get any linking error reports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4696: Update FlatLaf from 2.4 to 2.5
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4696:
URL: https://github.com/apache/netbeans/pull/4696#issuecomment-1264692325
Thanks @matthiasblaesing Possibly should go directly in `modules/lib` rather than `modules/lib/flatlaf` though? The lib folder has a defined structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4696: Update FlatLaf from 2.4 to 2.5
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4696:
URL: https://github.com/apache/netbeans/pull/4696#issuecomment-1280738286
Opened #4803 with conflicts resolved instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net closed pull request #4696: Update FlatLaf from 2.4 to 2.5
Posted by GitBox <gi...@apache.org>.
neilcsmith-net closed pull request #4696: Update FlatLaf from 2.4 to 2.5
URL: https://github.com/apache/netbeans/pull/4696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists