[GitHub] [hive] adriannistor edited a comment on pull request #1248: HIVE-23841: Field writers is an HashSet, i.e., not thread-safe. Field writers is typically protected by synchronization on lock, but not in 1 location.

[GitBox <gi...@apache.org>]

adriannistor edited a comment on pull request #1248:
URL: https://github.com/apache/hive/pull/1248#issuecomment-657887992


   I see this failure:
   
   http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-1248/1/tests
   
   about `testExecuteStatementParallel – org.apache.hive.service.cli.TestEmbeddedThriftBinaryCLIService`
   
   But somehow this failure / test does not seem related to the change made.
   
   Let me know if you have any suggestions (e.g., maybe the fix needs 2 locks, both `INSTANCE`, which is really `this` and `lock` --- though seems improbable).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org