[GitHub] [spark] amaliujia commented on a diff in pull request #40861: [SPARK-43032] streaming query manager

["amaliujia (via GitHub)" <gi...@apache.org>]

amaliujia commented on code in PR #40861:
URL: https://github.com/apache/spark/pull/40861#discussion_r1171905886


##########
connector/connect/common/src/main/protobuf/spark/connect/base.proto:
##########
@@ -304,8 +304,11 @@ message ExecutePlanResponse {
     // Response for commands on a streaming query.
     StreamingQueryCommandResult streaming_query_command_result = 9;
 
+    // Response for commands on the streaming query manager.
+    StreamingQueryManagerCommandResult streaming_query_manager_command_result = 10;
+
     // Response for 'SparkContext.resources'.
-    GetResourcesCommandResult get_resources_command_result = 10;
+    GetResourcesCommandResult get_resources_command_result = 11;

Review Comment:
   This is a breaking change... 
   
   probably you just do `StreamingQueryManagerCommandResult streaming_query_manager_command_result = 11;` and do not re-use existing proto number



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org