[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #3638: Ensure MetricsConfig is immutable

[GitBox <gi...@apache.org>]

RussellSpitzer commented on a change in pull request #3638:
URL: https://github.com/apache/iceberg/pull/3638#discussion_r760370554



##########
File path: core/src/main/java/org/apache/iceberg/MetricsConfig.java
##########
@@ -20,12 +20,15 @@
 package org.apache.iceberg;
 
 import java.io.Serializable;
+import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 import java.util.Set;
+import javax.annotation.concurrent.Immutable;

Review comment:
       Is this the first usage of the annotation in the project? What are the benefits of using it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org