You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2019/09/24 21:22:00 UTC
[jira] [Commented] (GEODE-7235) Disable new Clang warnings to fix
build for now
[ https://issues.apache.org/jira/browse/GEODE-7235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16937201#comment-16937201 ]
ASF subversion and git services commented on GEODE-7235:
--------------------------------------------------------
Commit 05710df47b886b831b4ee49b68faf971a1205a0e in geode-native's branch refs/heads/develop from Blake Bender
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=05710df ]
GEODE-7235: Disable a couple of new Clang warnings temporarily (#527)
* GEODE-7235: Disable a couple of new Clang warnings temporarily
* GEODE-7235: Make disabled warnings platform-dependent
- Got a new version of the compiler from Apple, this is breaking Mac builds
- Turns out Travis CI also uses Clang, but an older version that doesn't recognize these warnings, so there you get a warning about unrecognized warnings
Co-authored-by Michael Oleske <mo...@pivotal.io>
> Disable new Clang warnings to fix build for now
> -----------------------------------------------
>
> Key: GEODE-7235
> URL: https://issues.apache.org/jira/browse/GEODE-7235
> Project: Geode
> Issue Type: Bug
> Components: native client
> Reporter: Blake Bender
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Apple pushed an XCode update a couple of days ago to version `
> Apple clang version 11.0.0 (clang-1100.0.33.8)`. This version flags some new warnings in our code, and since we have warnings-as-errors turned on we blow up. Fixing these warnings is non-trivial, so we need to disable them in the top-level CMakeLists.txt and file another Jira issue to do the real fix.
> * Steps to repro:
> Sync up to the latest `develop` branch of Native Client on a Mac and build
> * Expected Result:
> Geode Native builds, and produces our libraries
> * Actual Result:
> Clang warns about "implicitly deleted copy/move ctors declared as default" in a product header, gives a warning about UTF-8 string literals in test code, then build fails.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)