You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@age.apache.org by GitBox <gi...@apache.org> on 2021/09/09 13:02:38 UTC

[GitHub] [incubator-age] muhammadshoaib opened a new pull request #115: Labels creation functions

muhammadshoaib opened a new pull request #115:
URL: https://github.com/apache/incubator-age/pull/115


   > Patch to create labels for vertices and edges
   >
   > Two more function create_vlabel and create_elabel has been added.
   > User can call these functions to create blank labels.
   >
   > Regression tests have not been added yet.
   >
   > Usage as following:
   >
   > SELECT create_vlabel('cypher', 'vlabel_1');
   > SELECT create_elabel('cypher', 'elabel_1');
   >
   > modified makefile to support UTF.
   > This test was failing on my docker.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-age] jrgemignani merged pull request #115: Labels creation functions

Posted by GitBox <gi...@apache.org>.
jrgemignani merged pull request #115:
URL: https://github.com/apache/incubator-age/pull/115


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-age] jrgemignani commented on pull request #115: Labels creation functions

Posted by GitBox <gi...@apache.org>.
jrgemignani commented on pull request #115:
URL: https://github.com/apache/incubator-age/pull/115#issuecomment-923136546


   Everything looks great! It just needs a few more regression tests with a few comment for failure cases i.e. showing it failing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-age] muhammadshoaib commented on a change in pull request #115: Labels creation functions

Posted by GitBox <gi...@apache.org>.
muhammadshoaib commented on a change in pull request #115:
URL: https://github.com/apache/incubator-age/pull/115#discussion_r705871546



##########
File path: src/backend/commands/graph_commands.c
##########
@@ -149,6 +259,8 @@ static Oid create_schema_for_graph(const Name graph_name)
 
 PG_FUNCTION_INFO_V1(drop_graph);
 
+// SELECT create_vlabel("Person'):

Review comment:
       I have removed this line. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-age] JoshInnis commented on a change in pull request #115: Labels creation functions

Posted by GitBox <gi...@apache.org>.
JoshInnis commented on a change in pull request #115:
URL: https://github.com/apache/incubator-age/pull/115#discussion_r705619801



##########
File path: src/backend/commands/graph_commands.c
##########
@@ -149,6 +259,8 @@ static Oid create_schema_for_graph(const Name graph_name)
 
 PG_FUNCTION_INFO_V1(drop_graph);
 
+// SELECT create_vlabel("Person'):

Review comment:
       I believe this line needs to be removed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-age] jrgemignani merged pull request #115: Labels creation functions

Posted by GitBox <gi...@apache.org>.
jrgemignani merged pull request #115:
URL: https://github.com/apache/incubator-age/pull/115


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org