You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/11 07:52:33 UTC

[GitHub] [flink] slinkydeveloper commented on a diff in pull request #19237: [FLINK-26725][table] Support the new type inference in Scala Table API aggregate functions

slinkydeveloper commented on code in PR #19237:
URL: https://github.com/apache/flink/pull/19237#discussion_r847039932


##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/utils/OperationTreeBuilder.java:
##########
@@ -694,12 +699,10 @@ protected AggregateWithAlias defaultMethod(Expression expression) {
         private void validateAlias(
                 List<String> aliases,
                 ResolvedExpression resolvedExpression,
-                Boolean isRowbasedAggregate) {
+                int fieldCount,
+                Boolean isRowBasedAggregate) {

Review Comment:
   Why this is boxed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org